fix(instance): server delete with scratch storage (#3366)

Author: Codelax

internal/namespaces/instance/v1/custom_server.go

@@ -811,6 +811,8 @@ func serverDeleteCommand() *core.Command {
 					continue
 				case deleteServerArgs.WithVolumes == withVolumesBlock && volume.VolumeType != instance.VolumeServerVolumeTypeBSSD:
 					continue
+				case volume.VolumeType == instance.VolumeServerVolumeTypeScratch:
+					continue
 				}
 				err = api.DeleteVolume(&instance.DeleteVolumeRequest{
 					Zone:     deleteServerArgs.Zone,

internal/namespaces/instance/v1/custom_server_create_test.go

@@ -490,7 +490,7 @@ func Test_CreateServerErrors(t *testing.T) {
 func Test_CreateServerScratchStorage(t *testing.T) {
 	t.Run("Default scratch storage", core.Test(&core.TestConfig{
 		Commands: GetCommands(),
-		Cmd:      "scw instance server create type=H100-1-80G image=ubuntu_jammy_gpu_os_12",
+		Cmd:      "scw instance server create type=H100-1-80G image=ubuntu_jammy_gpu_os_12 zone=fr-par-2",
 		Check: core.TestCheckCombine(
 			core.TestCheckGolden(),
 			func(t *testing.T, ctx *core.CheckFuncCtx) {
@@ -509,6 +509,7 @@ func Test_CreateServerScratchStorage(t *testing.T) {
 				assert.Equal(t, additionalVolume.VolumeType, instance.VolumeServerVolumeTypeScratch)
 			},
 		),
+		AfterFunc:       core.ExecAfterCmd("scw instance server delete {{ .CmdResult.ID }} zone=fr-par-2 with-volumes=all with-ip=true force-shutdown=true"),
 		DisableParallel: true,
 	}))
 }