fix(instance): prevent crash when server-type is only in PCU (#5437)

Author: Mia-Cross

internal/namespaces/instance/v1/custom_server_type.go

@@ -44,7 +44,7 @@ func serverTypesListMarshalerFunc(i any, opt *human.MarshalOpt) (string, error)
 		Arch             string
 		Bandwidth        scw.Size
 		Availability     instance.ServerTypesAvailability
-		MaxFileSystems   uint32
+		MaxFileSystems   *uint32
 	}
 
 	customServerTypes := i.([]*customServerType)
@@ -82,7 +82,7 @@ type customServerType struct {
 	Arch               string                           `json:"arch"`
 	Bandwidth          scw.Size                         `json:"bandwidth"`
 	Availability       instance.ServerTypesAvailability `json:"availability"`
-	MaxFileSystems     uint32                           `json:"max_file_systems"`
+	MaxFileSystems     *uint32                          `json:"max_file_systems"`
 }
 
 // serverTypeListBuilder transforms the server map into a list to display a
@@ -154,17 +154,19 @@ func serverTypeListBuilder(c *core.Command) *core.Command {
 			}
 
 			name := pcuServerType.Properties.Instance.OfferID
-			computeServerType := computeServerTypes.Servers[name]
 			serverType := &customServerType{
-				Name:           name,
-				HourlyPrice:    pcuServerType.Price.RetailPrice,
-				MaxFileSystems: computeServerType.Capabilities.MaxFileSystems,
+				Name:        name,
+				HourlyPrice: pcuServerType.Price.RetailPrice,
 			}
 
 			if availability, exists := availabilitiesResponse.Servers[name]; exists {
 				serverType.Availability = availability.Availability
 			}
 
+			if computeServerType, ok := computeServerTypes.Servers[name]; ok {
+				serverType.MaxFileSystems = new(computeServerType.Capabilities.MaxFileSystems)
+			}
+
 			if pcuServerType.Properties.Hardware != nil {
 				if pcuServerType.Properties.Hardware.CPU != nil {
 					serverType.CPU = pcuServerType.Properties.Hardware.CPU.Virtual.Count

internal/namespaces/instance/v1/custom_server_type_test.go

@@ -8,12 +8,39 @@ import (
 )
 
 func Test_ServerTypeList(t *testing.T) {
-	t.Run("server-type list", core.Test(&core.TestConfig{
+	t.Run("on fr-par-1", core.Test(&core.TestConfig{
 		Commands: instance.GetCommands(),
 		Cmd:      "scw instance server-type list",
 		Check: core.TestCheckCombine(
 			core.TestCheckGolden(),
 			core.TestCheckExitCode(0),
 		),
 	}))
+
+	t.Run("on nl-ams-2", core.Test(&core.TestConfig{
+		Commands: instance.GetCommands(),
+		Cmd:      "scw instance server-type list zone=nl-ams-2",
+		Check: core.TestCheckCombine(
+			core.TestCheckGolden(),
+			core.TestCheckExitCode(0),
+		),
+	}))
+
+	t.Run("on pl-waw-1", core.Test(&core.TestConfig{
+		Commands: instance.GetCommands(),
+		Cmd:      "scw instance server-type list zone=pl-waw-1",
+		Check: core.TestCheckCombine(
+			core.TestCheckGolden(),
+			core.TestCheckExitCode(0),
+		),
+	}))
+
+	t.Run("on it-mil-1", core.Test(&core.TestConfig{
+		Commands: instance.GetCommands(),
+		Cmd:      "scw instance server-type list zone=it-mil-1",
+		Check: core.TestCheckCombine(
+			core.TestCheckGolden(),
+			core.TestCheckExitCode(0),
+		),
+	}))
 }