Skip to content

Commit 3ccff10

Browse files
feat(k8s): allow patching security_group_id on existing pools (#5281)
Co-authored-by: Leïla Marabese <lmarabese@scaleway.com>
1 parent c278ab4 commit 3ccff10

File tree

5 files changed

+12
-3
lines changed

5 files changed

+12
-3
lines changed

cmd/scw/testdata/test-all-usage-k8s-pool-update-usage.golden

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -29,6 +29,7 @@ ARGS:
2929
[kubelet-args.{key}] New Kubelet arguments to be used by this pool. Note that this feature is experimental
3030
[upgrade-policy.max-unavailable]
3131
[upgrade-policy.max-surge]
32+
[security-group-id] Security group ID in which all the nodes of the pool will be moved
3233
[region=fr-par] Region to target. If none is passed will use default region from the config (fr-par | nl-ams | pl-waw)
3334

3435
FLAGS:

docs/commands/k8s.md

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1171,6 +1171,7 @@ scw k8s pool update <pool-id ...> [arg=value ...]
11711171
| kubelet-args.{key} | | New Kubelet arguments to be used by this pool. Note that this feature is experimental |
11721172
| upgrade-policy.max-unavailable | | |
11731173
| upgrade-policy.max-surge | | |
1174+
| security-group-id | | Security group ID in which all the nodes of the pool will be moved |
11741175
| region | Default: `fr-par`<br />One of: `fr-par`, `nl-ams`, `pl-waw` | Region to target. If none is passed will use default region from the config |
11751176

11761177

go.mod

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -23,7 +23,7 @@ require (
2323
github.com/mattn/go-isatty v0.0.20
2424
github.com/moby/buildkit v0.26.3
2525
github.com/opencontainers/go-digest v1.0.0
26-
github.com/scaleway/scaleway-sdk-go v1.0.0-beta.36.0.20260108164656-13fa9cb46cf9
26+
github.com/scaleway/scaleway-sdk-go v1.0.0-beta.36.0.20260113155846-8c9140c080b2
2727
github.com/skratchdot/open-golang v0.0.0-20200116055534-eef842397966
2828
github.com/spf13/cobra v1.10.2
2929
github.com/spf13/pflag v1.0.10

go.sum

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -468,8 +468,8 @@ github.com/rogpeppe/go-internal v1.14.1/go.mod h1:MaRKkUm5W0goXpeCfT7UZI6fk/L7L7
468468
github.com/russross/blackfriday/v2 v2.1.0/go.mod h1:+Rmxgy9KzJVeS9/2gXHxylqXiyQDYRxCVz55jmeOWTM=
469469
github.com/sabhiram/go-gitignore v0.0.0-20210923224102-525f6e181f06 h1:OkMGxebDjyw0ULyrTYWeN0UNCCkmCWfjPnIA2W6oviI=
470470
github.com/sabhiram/go-gitignore v0.0.0-20210923224102-525f6e181f06/go.mod h1:+ePHsJ1keEjQtpvf9HHw0f4ZeJ0TLRsxhunSI2hYJSs=
471-
github.com/scaleway/scaleway-sdk-go v1.0.0-beta.36.0.20260108164656-13fa9cb46cf9 h1:DD1OQFOyfAies6NJIOca2tGBTcIuvLfNF0r0qDF5VQ4=
472-
github.com/scaleway/scaleway-sdk-go v1.0.0-beta.36.0.20260108164656-13fa9cb46cf9/go.mod h1:LEsDu4BubxK7/cWhtlQWfuxwL4rf/2UEpxXz1o1EMtM=
471+
github.com/scaleway/scaleway-sdk-go v1.0.0-beta.36.0.20260113155846-8c9140c080b2 h1:evw9xPSaieASL+tHzSPxkd5fB0fvQ1sJhhsBOaU96FM=
472+
github.com/scaleway/scaleway-sdk-go v1.0.0-beta.36.0.20260113155846-8c9140c080b2/go.mod h1:VbEqG0nAXcEFyHLKWwbhgbDNimnLf24Qat73/12DU9o=
473473
github.com/sclevine/spec v1.4.0 h1:z/Q9idDcay5m5irkZ28M7PtQM4aOISzOpj4bUPkDee8=
474474
github.com/sclevine/spec v1.4.0/go.mod h1:LvpgJaFyvQzRvc1kaDs0bulYwzC70PbiYjC4QnFHkOM=
475475
github.com/secure-systems-lab/go-securesystemslib v0.9.1 h1:nZZaNz4DiERIQguNy0cL5qTdn9lR8XKHf4RUyG1Sx3g=

internal/namespaces/k8s/v1/k8s_cli.go

Lines changed: 7 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -2033,6 +2033,13 @@ func k8sPoolUpdate() *core.Command {
20332033
Deprecated: false,
20342034
Positional: false,
20352035
},
2036+
{
2037+
Name: "security-group-id",
2038+
Short: `Security group ID in which all the nodes of the pool will be moved`,
2039+
Required: false,
2040+
Deprecated: false,
2041+
Positional: false,
2042+
},
20362043
core.RegionArgSpec(
20372044
scw.RegionFrPar,
20382045
scw.RegionNlAms,

0 commit comments

Comments
 (0)