chore: migrate to go 1.24 (#4538)

remyleone · web-flow · commit 368a010ef1db · 2025-02-26T13:07:30.000Z
diff --git a/.github/workflows/coverage.yml b/.github/workflows/coverage.yml
@@ -15,7 +15,7 @@ jobs:
           fetch-depth: 2
       - uses: actions/setup-go@v5
         with:
-          go-version: '1.22'
+          go-version: '1.24'
       - name: Run coverage
         run: go test -coverprofile=coverage.out -covermode=count ./...
       - name: Upload coverage to Codecov
diff --git a/.github/workflows/docs.yml b/.github/workflows/docs.yml
@@ -11,7 +11,7 @@ jobs:
       - uses: actions/checkout@v4
       - uses: actions/setup-go@v5
         with:
-          go-version: '1.22'
+          go-version: '1.24'
       - name: Generate code
         run: go run ./cmd/scw-doc-gen
         env:
diff --git a/.github/workflows/nightly.yml b/.github/workflows/nightly.yml
@@ -56,7 +56,7 @@ jobs:
       - name: Install Go
         uses: actions/setup-go@v5
         with:
-          go-version: 1.22
+          go-version: 1.24
       - name: Run Acceptance Tests
         run: go test -v ./internal/namespaces/${{ matrix.products }}/... -timeout=4h
         env:
@@ -98,7 +98,7 @@ jobs:
       - name: Install Go
         uses: actions/setup-go@v5
         with:
-          go-version: 1.22
+          go-version: 1.24
       - name: Run Sweepers
         run: go run -v ./cmd/scw-sweeper
         env:
diff --git a/.github/workflows/release.yml b/.github/workflows/release.yml
@@ -20,7 +20,7 @@ jobs:
       - name: Set up Go
         uses: actions/setup-go@v5
         with:
-          go-version: '1.22'
+          go-version: '1.24'
 
       - name: Run GoReleaser
         uses: goreleaser/goreleaser-action@v6
@@ -38,7 +38,7 @@ jobs:
       - name: Install Go
         uses: actions/setup-go@v5
         with:
-          go-version: '1.22'
+          go-version: '1.24'
       - name: Install pnpm
         uses: pnpm/action-setup@v4
         with:
diff --git a/.github/workflows/unit-tests.yaml b/.github/workflows/unit-tests.yaml
@@ -8,7 +8,6 @@ jobs:
   os-tests:
     strategy:
       matrix:
-        go-version: [1.22.x]
         platform: [ubuntu-latest, macos-latest, windows-latest]
     runs-on: ${{ matrix.platform }}
     steps:
@@ -24,18 +23,14 @@ jobs:
       - name: Install Go
         uses: actions/setup-go@v5
         with:
-          go-version: ${{ matrix.go-version }}
+          go-version: '1.24'
       - name: Run unit tests
         run: go test ./...
       - name: Execute main binary # Test the runtime for potential panics.
         run: go run cmd/scw/main.go -h
 
   build-tests:
-    strategy:
-      matrix:
-        go-version: [1.22.x]
-        platform: [ubuntu-latest]
-    runs-on: ${{ matrix.platform }}
+    runs-on: ubuntu-latest
     steps:
       # Checkout should always be before setup-go to ensure caching is working
       - name: Checkout
@@ -45,7 +40,7 @@ jobs:
       - name: Install Go
         uses: actions/setup-go@v5
         with:
-          go-version: ${{ matrix.go-version }}
+          go-version: '1.24'
       - name: Build binaries
         run: ./scripts/build.sh
       - name: Print binaries size
diff --git a/.github/workflows/wasm.yml b/.github/workflows/wasm.yml
@@ -6,11 +6,7 @@ on:
 
 jobs:
   build-and-test:
-    strategy:
-      matrix:
-        go-version: [1.22.x]
-        platform: [ubuntu-latest]
-    runs-on: ${{ matrix.platform }}
+    runs-on: ubuntu-latest
     steps:
       # Checkout should always be before setup-go to ensure caching is working
       - name: Checkout
@@ -20,7 +16,7 @@ jobs:
       - name: Install Go
         uses: actions/setup-go@v5
         with:
-          go-version: ${{ matrix.go-version }}
+          go-version: '1.24'
       - name: Install pnpm
         uses: pnpm/action-setup@v4
         with:
diff --git a/.golangci.yml b/.golangci.yml
@@ -62,7 +62,6 @@ linters:
     - staticcheck
     - stylecheck # Stylecheck is a replacement for golint [fast: false, auto-fix: false]
     - tagalign # check that struct tags are well aligned [fast: true, auto-fix: true]
-    - tenv # tenv is analyzer that detects using os.Setenv instead of t.Setenv since Go1.17 [fast: false, auto-fix: false]
     - testifylint # Checks usage of github.com/stretchr/testify. [fast: false, auto-fix: false]
     - testpackage # linter that makes you use a separate _test package [fast: true, auto-fix: false]
     - thelper # thelper detects golang test helpers without t.Helper() call and checks the consistency of test helpers [fast: false, auto-fix: false]
diff --git a/Dockerfile b/Dockerfile
@@ -1,4 +1,4 @@
-FROM golang:1.23-alpine3.19 AS builder
+FROM golang:1.24-alpine3.21 AS builder
 
 ENV BUILD_IN_DOCKER true
 ARG VERSION
diff --git a/core/autocomplete_test.go b/core/autocomplete_test.go
@@ -114,7 +114,7 @@ func runAutocompleteTest(ctx context.Context, tc *autoCompleteTestCase) func(*te
 }
 
 func TestAutocomplete(t *testing.T) {
-	ctx := core.InjectMeta(context.Background(), &core.Meta{
+	ctx := core.InjectMeta(t.Context(), &core.Meta{
 		Commands: testAutocompleteGetCommands(),
 	})
 
@@ -253,7 +253,7 @@ func TestAutocompleteArgs(t *testing.T) {
 			}, nil
 		},
 	})
-	ctx := core.InjectMeta(context.Background(), &core.Meta{
+	ctx := core.InjectMeta(t.Context(), &core.Meta{
 		Commands: commands,
 		BetaMode: true,
 	})
@@ -272,7 +272,7 @@ func TestAutocompleteArgs(t *testing.T) {
 
 func TestAutocompleteProfiles(t *testing.T) {
 	commands := testAutocompleteGetCommands()
-	ctx := core.InjectMeta(context.Background(), &core.Meta{
+	ctx := core.InjectMeta(t.Context(), &core.Meta{
 		Commands: commands,
 		BetaMode: true,
 		Platform: terminal.NewPlatform(""),
@@ -300,7 +300,7 @@ func TestAutocompleteProfiles(t *testing.T) {
 }
 
 func TestAutocompleteDeprecatedCommand(t *testing.T) {
-	ctx := core.InjectMeta(context.Background(), &core.Meta{
+	ctx := core.InjectMeta(t.Context(), &core.Meta{
 		Commands: testAutocompleteGetCommands(),
 	})
 
diff --git a/core/cobra_usage_builder_test.go b/core/cobra_usage_builder_test.go
@@ -1,7 +1,6 @@
 package core_test
 
 import (
-	"context"
 	"reflect"
 	"testing"
 
@@ -41,7 +40,7 @@ func Test_buildUsageArgs(t *testing.T) {
   [root-volume.name]                  Root volume name
   [additional-volumes.{index}.name]   Additional volume name`
 
-	got := core.BuildUsageArgs(context.Background(), &core.Command{
+	got := core.BuildUsageArgs(t.Context(), &core.Command{
 		ArgsType: reflect.TypeOf(instanceListServerArgs{}),
 		ArgSpecs: core.ArgSpecs{
 			{
diff --git a/core/default_test.go b/core/default_test.go
@@ -1,7 +1,6 @@
 package core_test
 
 import (
-	"context"
 	"testing"
 
 	"github.com/scaleway/scaleway-cli/v2/core"
@@ -19,7 +18,7 @@ func Test_ApplyDefaultValues(t *testing.T) {
 	run := func(tc *testCase) func(t *testing.T) {
 		return func(t *testing.T) {
 			t.Helper()
-			result := core.ApplyDefaultValues(context.Background(), tc.argSpecs, tc.rawArgs)
+			result := core.ApplyDefaultValues(t.Context(), tc.argSpecs, tc.rawArgs)
 			assert.Equal(t, tc.expected, result)
 		}
 	}
diff --git a/core/testing.go b/core/testing.go
@@ -319,7 +319,7 @@ func Test(config *TestConfig) func(t *testing.T) {
 
 		ctx := config.Ctx
 		if ctx == nil {
-			ctx = context.Background()
+			ctx = t.Context()
 		}
 		if len(config.PromptResponseMocks) > 0 {
 			ctx = interactive.InjectMockResponseToContext(ctx, config.PromptResponseMocks)
diff --git a/core/validate_test.go b/core/validate_test.go
@@ -40,7 +40,7 @@ func Test_DefaultCommandValidateFunc(t *testing.T) {
 	run := func(testCase TestCase) func(t *testing.T) {
 		return func(t *testing.T) {
 			t.Helper()
-			err := core.DefaultCommandValidateFunc()(context.Background(), testCase.command, testCase.parsedArguments, testCase.rawArgs)
+			err := core.DefaultCommandValidateFunc()(t.Context(), testCase.command, testCase.parsedArguments, testCase.rawArgs)
 			assert.Equal(t, errors.New("arg validation called"), err)
 		}
 	}
@@ -198,15 +198,15 @@ func Test_DefaultCommandRequiredFunc(t *testing.T) {
 	runOK := func(testCase TestCase) func(t *testing.T) {
 		return func(t *testing.T) {
 			t.Helper()
-			err := core.DefaultCommandValidateFunc()(context.Background(), testCase.command, testCase.parsedArguments, testCase.rawArgs)
+			err := core.DefaultCommandValidateFunc()(t.Context(), testCase.command, testCase.parsedArguments, testCase.rawArgs)
 			assert.NoError(t, err)
 		}
 	}
 
 	runErr := func(testCase TestCase, argName string) func(t *testing.T) {
 		return func(t *testing.T) {
 			t.Helper()
-			err := core.DefaultCommandValidateFunc()(context.Background(), testCase.command, testCase.parsedArguments, testCase.rawArgs)
+			err := core.DefaultCommandValidateFunc()(t.Context(), testCase.command, testCase.parsedArguments, testCase.rawArgs)
 			assert.Equal(t, core.MissingRequiredArgumentError(argName), err)
 		}
 	}
diff --git a/go.mod b/go.mod
@@ -1,8 +1,8 @@
 module github.com/scaleway/scaleway-cli/v2
 
-go 1.22
+go 1.24
 
-toolchain go1.22.2
+toolchain go1.24.0
 
 require (
 	github.com/aws/aws-sdk-go-v2 v1.36.2
diff --git a/internal/interactive/prompt_test.go b/internal/interactive/prompt_test.go
@@ -2,7 +2,6 @@ package interactive_test
 
 import (
 	"bytes"
-	"context"
 	"testing"
 
 	"github.com/scaleway/scaleway-cli/v2/internal/interactive"
@@ -18,7 +17,7 @@ func TestPromptStringWithConfig(t *testing.T) {
 
 		interactive.SetOutputWriter(buffer)
 
-		ctx := context.Background()
+		ctx := t.Context()
 		ctx = interactive.InjectMockResponseToContext(ctx, []string{"mock1", "mock2"})
 
 		s, err := interactive.PromptStringWithConfig(&interactive.PromptStringConfig{
diff --git a/internal/namespaces/login/webcallback/webcallback_test.go b/internal/namespaces/login/webcallback/webcallback_test.go
@@ -18,7 +18,7 @@ func TestWebCallback(t *testing.T) {
 	assert.NoError(t, wb.Start())
 	assert.NoError(t, wb.Trigger("test-token", time.Second))
 
-	ctx, cancelFunc := context.WithTimeout(context.Background(), time.Second)
+	ctx, cancelFunc := context.WithTimeout(t.Context(), time.Second)
 	t.Cleanup(cancelFunc)
 
 	resp, err := wb.Wait(ctx)
diff --git a/internal/tasks/tasks_test.go b/internal/tasks/tasks_test.go
@@ -30,7 +30,7 @@ func TestGeneric(t *testing.T) {
 		return int(i) / 4, nil
 	})
 
-	res, err := ts.Execute(context.Background(), 12)
+	res, err := ts.Execute(t.Context(), 12)
 	require.NoError(t, err)
 	assert.Equal(t, 3, res)
 }
@@ -86,7 +86,7 @@ func TestCleanup(t *testing.T) {
 		return nil, errors.New("fail")
 	})
 
-	_, err := ts.Execute(context.Background(), nil)
+	_, err := ts.Execute(t.Context(), nil)
 	require.Error(t, err, "Execute should return error after cleanup")
 	assert.Equal(t, 3, clean, "3 task cleanup should have been executed")
 }
@@ -98,7 +98,7 @@ func TestCleanupOnContext(t *testing.T) {
 	ts := tasks.Begin()
 
 	clean := 0
-	ctx := context.Background()
+	ctx := t.Context()
 
 	tasks.Add(ts, "TaskFunc 1", func(task *tasks.Task, _ interface{}) (nextArgs interface{}, err error) {
 		task.AddToCleanUp(func(_ context.Context) error {
diff --git a/wasm/wasm_exec.cjs b/wasm/wasm_exec.cjs
@@ -20,6 +20,7 @@
         O_TRUNC: -1,
         O_APPEND: -1,
         O_EXCL: -1,
+        O_DIRECTORY: -1,
       }, // unused
       writeSync(fd, buf) {
         outputBuf += decoder.decode(buf)
@@ -141,6 +142,14 @@
     }
   }
 
+  if (!globalThis.path) {
+    globalThis.path = {
+      resolve(...pathSegments) {
+        return pathSegments.join('/')
+      },
+    }
+  }
+
   if (!globalThis.crypto) {
     throw new Error(
       'globalThis.crypto is not available, polyfill required (crypto.getRandomValues only)',
@@ -286,10 +295,16 @@
         )
       }
 
+      const testCallExport = (a, b) => {
+        this._inst.exports.testExport0()
+        return this._inst.exports.testExport(a, b)
+      }
+
       const timeOrigin = Date.now() - performance.now()
       this.importObject = {
         _gotest: {
           add: (a, b) => a + b,
+          callExport: testCallExport,
         },
         gojs: {
           // Go's SP does not change as long as no Go code is running. Some operations (e.g. calls, getters and setters)

Original file line number	Diff line number	Diff line change
`@@ -1,4 +1,4 @@`
`1`		`-FROM golang:1.23-alpine3.19 AS builder`
	`1`	`+FROM golang:1.24-alpine3.21 AS builder`
`2`	`2`
`3`	`3`	`ENV BUILD_IN_DOCKER true`
`4`	`4`	`ARG VERSION`