feat(secret-manager): don't exclude password_generation field (#3143)

Author: scaleway-bot

cmd/scw/testdata/test-all-usage-secret-version-create-usage.golden

@@ -6,12 +6,17 @@ USAGE:
   scw secret version create [arg=value ...]
 
 ARGS:
-  secret-id            ID of the secret
-  data                 Content of the secret version. Base64 is handled by the SDK (Support file loading with @/path/to/file)
-  [description]        Description of the version
-  [disable-previous]   Disable the previous secret version
-  [data-crc32]         (Optional.) The CRC32 checksum of the data as a base-10 integer
-  [region=fr-par]      Region to target. If none is passed will use default region from the config (fr-par)
+  secret-id                                    ID of the secret
+  data                                         Content of the secret version. Base64 is handled by the SDK (Support file loading with @/path/to/file)
+  [description]                                Description of the version
+  [disable-previous]                           Disable the previous secret version
+  [password-generation.length]                 Length of the password to generate (between 1 and 1024)
+  [password-generation.no-lowercase-letters]   Do not include lower case letters by default in the alphabet
+  [password-generation.no-uppercase-letters]   Do not include upper case letters by default in the alphabet
+  [password-generation.no-digits]              Do not include digits by default in the alphabet
+  [password-generation.additional-chars]       Additional ascii characters to be included in the alphabet
+  [data-crc32]                                 (Optional.) The CRC32 checksum of the data as a base-10 integer
+  [region=fr-par]                              Region to target. If none is passed will use default region from the config (fr-par)
 
 FLAGS:
   -h, --help   help for create

docs/commands/secret.md

@@ -201,6 +201,11 @@ scw secret version create [arg=value ...]
 | data | Required | Content of the secret version. Base64 is handled by the SDK |
 | description |  | Description of the version |
 | disable-previous |  | Disable the previous secret version |
+| password-generation.length |  | Length of the password to generate (between 1 and 1024) |
+| password-generation.no-lowercase-letters |  | Do not include lower case letters by default in the alphabet |
+| password-generation.no-uppercase-letters |  | Do not include upper case letters by default in the alphabet |
+| password-generation.no-digits |  | Do not include digits by default in the alphabet |
+| password-generation.additional-chars |  | Additional ascii characters to be included in the alphabet |
 | data-crc32 |  | (Optional.) The CRC32 checksum of the data as a base-10 integer |
 | region | Default: `fr-par`<br />One of: `fr-par` | Region to target. If none is passed will use default region from the config |
 

go.mod

@@ -26,7 +26,7 @@ require (
 	github.com/moby/buildkit v0.11.6
 	github.com/opencontainers/go-digest v1.0.0
 	github.com/pkg/errors v0.9.1
-	github.com/scaleway/scaleway-sdk-go v1.0.0-beta.17.0.20230524152841-3978517139f0
+	github.com/scaleway/scaleway-sdk-go v1.0.0-beta.17.0.20230526161530-cf508019231d
 	github.com/spf13/cobra v1.7.0
 	github.com/spf13/pflag v1.0.5
 	github.com/stretchr/testify v1.8.3

go.sum

@@ -483,8 +483,8 @@ github.com/rogpeppe/go-internal v1.10.0/go.mod h1:UQnix2H7Ngw/k4C5ijL5+65zddjncj
 github.com/russross/blackfriday/v2 v2.1.0/go.mod h1:+Rmxgy9KzJVeS9/2gXHxylqXiyQDYRxCVz55jmeOWTM=
 github.com/sabhiram/go-gitignore v0.0.0-20210923224102-525f6e181f06 h1:OkMGxebDjyw0ULyrTYWeN0UNCCkmCWfjPnIA2W6oviI=
 github.com/sabhiram/go-gitignore v0.0.0-20210923224102-525f6e181f06/go.mod h1:+ePHsJ1keEjQtpvf9HHw0f4ZeJ0TLRsxhunSI2hYJSs=
-github.com/scaleway/scaleway-sdk-go v1.0.0-beta.17.0.20230524152841-3978517139f0 h1:U4HT3FlDTJ1jtdQ9zQXoxFmSthf5O/hCLn3Vo44FWc0=
-github.com/scaleway/scaleway-sdk-go v1.0.0-beta.17.0.20230524152841-3978517139f0/go.mod h1:fCa7OJZ/9DRTnOKmxvT6pn+LPWUptQAmHF/SBJUGEcg=
+github.com/scaleway/scaleway-sdk-go v1.0.0-beta.17.0.20230526161530-cf508019231d h1:qeI25+qrQ5MQaMFS2RgmAeAwUSWZSeYy5eYHnmW8vpk=
+github.com/scaleway/scaleway-sdk-go v1.0.0-beta.17.0.20230526161530-cf508019231d/go.mod h1:fCa7OJZ/9DRTnOKmxvT6pn+LPWUptQAmHF/SBJUGEcg=
 github.com/sclevine/spec v1.4.0 h1:z/Q9idDcay5m5irkZ28M7PtQM4aOISzOpj4bUPkDee8=
 github.com/secure-systems-lab/go-securesystemslib v0.4.0 h1:b23VGrQhTA8cN2CbBw7/FulN9fTtqYUdS5+Oxzt+DUE=
 github.com/sergi/go-diff v1.0.0/go.mod h1:0CfEIISq7TuYL3j771MWULgwwjU+GofnZX9QAmXWZgo=

internal/namespaces/secret/v1alpha1/secret_cli.go

@@ -350,6 +350,41 @@ func secretVersionCreate() *core.Command {
 				Deprecated: false,
 				Positional: false,
 			},
+			{
+				Name:       "password-generation.length",
+				Short:      `Length of the password to generate (between 1 and 1024)`,
+				Required:   false,
+				Deprecated: false,
+				Positional: false,
+			},
+			{
+				Name:       "password-generation.no-lowercase-letters",
+				Short:      `Do not include lower case letters by default in the alphabet`,
+				Required:   false,
+				Deprecated: false,
+				Positional: false,
+			},
+			{
+				Name:       "password-generation.no-uppercase-letters",
+				Short:      `Do not include upper case letters by default in the alphabet`,
+				Required:   false,
+				Deprecated: false,
+				Positional: false,
+			},
+			{
+				Name:       "password-generation.no-digits",
+				Short:      `Do not include digits by default in the alphabet`,
+				Required:   false,
+				Deprecated: false,
+				Positional: false,
+			},
+			{
+				Name:       "password-generation.additional-chars",
+				Short:      `Additional ascii characters to be included in the alphabet`,
+				Required:   false,
+				Deprecated: false,
+				Positional: false,
+			},
 			{
 				Name:       "data-crc32",
 				Short:      `(Optional.) The CRC32 checksum of the data as a base-10 integer`,