chore: migrate to go1.26 (#5332)

Author: remyleone

.github/workflows/lint.yml

@@ -35,7 +35,7 @@ jobs:
         uses: golangci/golangci-lint-action@1e7e51e771db61008b38414a730f564565cf7c20 # v9.2.0
         with:
           # Required: the version of golangci-lint is required and must be specified without patch version: we always use the latest patch version.
-          version: latest
+          version: v2.9.0
           args: --timeout 10m
 
   spelling:

Dockerfile

@@ -1,4 +1,4 @@
-FROM golang:1.25-alpine3.21 AS builder
+FROM golang:1.26-alpine3.23 AS builder
 
 ENV BUILD_IN_DOCKER=true
 ARG VERSION

core/human/marshal.go

@@ -461,8 +461,7 @@ func computeMaxCols(grid [][]string) int {
 func getDefaultFieldsOpt(t reflect.Type) []*MarshalFieldOpt {
 	results := []*MarshalFieldOpt(nil)
 	// Loop through all struct field
-	for fieldIdx := range t.NumField() {
-		field := t.Field(fieldIdx)
+	for field := range t.Fields() {
 		fieldType := field.Type
 
 		if field.Anonymous {

core/reflect.go

@@ -15,23 +15,21 @@ import (
 // becomes struct{FieldName string `json:"field_name"`}
 func newObjectWithForcedJSONTags(t reflect.Type) any {
 	structFieldsCopy := []reflect.StructField(nil)
-	for i := range t.NumField() {
-		fieldCopy := t.Field(i)
+	for fieldCopy := range t.Fields() {
 		if fieldCopy.Anonymous {
 			anonymousType := fieldCopy.Type
 			if anonymousType.Kind() == reflect.Ptr {
 				anonymousType = anonymousType.Elem()
 			}
-			for i := range anonymousType.NumField() {
-				fieldCopy := anonymousType.Field(i)
-				fieldCopy.Tag = reflect.StructTag(
+			for field := range anonymousType.Fields() {
+				field.Tag = reflect.StructTag(
 					`json:"` + strings.ReplaceAll(
-						strcase.ToBashArg(fieldCopy.Name),
+						strcase.ToBashArg(field.Name),
 						"-",
 						"_",
 					) + `"`,
 				)
-				structFieldsCopy = append(structFieldsCopy, fieldCopy)
+				structFieldsCopy = append(structFieldsCopy, field)
 			}
 		} else {
 			fieldCopy.Tag = reflect.StructTag(

core/testing.go

@@ -343,7 +343,7 @@ func Test(config *TestConfig) func(t *testing.T) {
 		}
 
 		// We need to set up this variable to ensure that relative date parsing stay consistent
-		args.TestForceNow = scw.TimePtr(time.Date(1970, 1, 1, 0, 0, 0, 0, time.UTC))
+		args.TestForceNow = new(time.Date(1970, 1, 1, 0, 0, 0, 0, time.UTC))
 
 		// Because human marshal of date is relative (e.g 3 minutes ago) we must make sure it stay consistent for golden to works.
 		// Here we return a constant string. We may need to find a better place to put this.

go.mod

@@ -1,6 +1,6 @@
 module github.com/scaleway/scaleway-cli/v2
 
-go 1.25.5
+go 1.26.0
 
 require (
 	github.com/aws/aws-sdk-go-v2 v1.41.1

internal/args/args.go

@@ -297,8 +297,7 @@ func listArgTypeFields(base string, argType reflect.Type) []string {
 	case reflect.Struct:
 		fields := []string(nil)
 
-		for i := range argType.NumField() {
-			field := argType.Field(i)
+		for field := range argType.Fields() {
 			fieldBase := base
 
 			// If this is an embedded struct, skip adding its name to base

internal/args/unmarshal_test.go

@@ -13,7 +13,7 @@ import (
 )
 
 func init() {
-	args.TestForceNow = scw.TimePtr(time.Date(1970, 1, 1, 0, 0, 0, 0, time.UTC))
+	args.TestForceNow = new(time.Date(1970, 1, 1, 0, 0, 0, 0, time.UTC))
 }
 
 func TestUnmarshalStruct(t *testing.T) {
@@ -205,7 +205,7 @@ func TestUnmarshalStruct(t *testing.T) {
 		},
 		expected: &Slice{
 			Strings:    []string(nil),
-			SlicePtr:   scw.StringsPtr([]string{}),
+			SlicePtr:   new([]string{}),
 			StringsPtr: []*string(nil),
 		},
 	}))

internal/editor/reflect_test.go

@@ -78,7 +78,7 @@ func Test_valueMapperPointersWithPointers(t *testing.T) {
 	src := struct {
 		Arg1 *string
 		Arg2 *int32
-	}{scw.StringPtr("1"), scw.Int32Ptr(1)}
+	}{new("1"), scw.Int32Ptr(1)}
 	dest := struct {
 		Arg1 *string
 		Arg2 *int32

internal/gofields/gofields.go

@@ -178,9 +178,7 @@ func listFields(t reflect.Type, parents []string, filter ListFieldFilter) []stri
 		return listFields(t.Elem(), append(parents, "<key>"), filter)
 	case reflect.Struct:
 		res := []string(nil)
-		for i := range t.NumField() {
-			field := t.Field(i)
-
+		for field := range t.Fields() {
 			if !isFieldPublic(field) {
 				continue
 			}