chore(instance): mark Volume's base_volume as deprecated (#3489)

Author: scaleway-bot

cmd/scw/testdata/test-all-usage-instance-volume-create-usage.golden

@@ -21,11 +21,13 @@ ARGS:
   [tags.{index}]       Volume tags
   [volume-type]        Volume type (l_ssd | b_ssd | unified | scratch | sbs_volume | sbs_snapshot)
   [size]               Volume disk size, must be a multiple of 512
-  [base-volume]        ID of the volume on which this volume will be based
   [base-snapshot]      ID of the snapshot on which this volume will be based
   [organization-id]    Organization ID to use. If none is passed the default organization ID will be used
   [zone=fr-par-1]      Zone to target. If none is passed will use default zone from the config (fr-par-1 | fr-par-2 | fr-par-3 | nl-ams-1 | nl-ams-2 | nl-ams-3 | pl-waw-1 | pl-waw-2 | pl-waw-3)
 
+DEPRECATED ARGS:
+  [base-volume]   ID of the volume on which this volume will be based
+
 FLAGS:
   -h, --help   help for create
 

docs/commands/instance.md

@@ -2913,7 +2913,7 @@ scw instance volume create [arg=value ...]
 | tags.{index} |  | Volume tags |
 | volume-type | One of: `l_ssd`, `b_ssd`, `unified`, `scratch`, `sbs_volume`, `sbs_snapshot` | Volume type |
 | size |  | Volume disk size, must be a multiple of 512 |
-| base-volume |  | ID of the volume on which this volume will be based |
+| ~~base-volume~~ | Deprecated | ID of the volume on which this volume will be based |
 | base-snapshot |  | ID of the snapshot on which this volume will be based |
 | organization-id |  | Organization ID to use. If none is passed the default organization ID will be used |
 | zone | Default: `fr-par-1`<br />One of: `fr-par-1`, `fr-par-2`, `fr-par-3`, `nl-ams-1`, `nl-ams-2`, `nl-ams-3`, `pl-waw-1`, `pl-waw-2`, `pl-waw-3` | Zone to target. If none is passed will use default zone from the config |

go.mod

@@ -24,7 +24,7 @@ require (
 	github.com/moby/buildkit v0.11.6
 	github.com/opencontainers/go-digest v1.0.0
 	github.com/pkg/errors v0.9.1
-	github.com/scaleway/scaleway-sdk-go v1.0.0-beta.21.0.20231110143144-15d133efb1a7
+	github.com/scaleway/scaleway-sdk-go v1.0.0-beta.21.0.20231113154526-f7d9669f9369
 	github.com/skratchdot/open-golang v0.0.0-20200116055534-eef842397966
 	github.com/spf13/cobra v1.8.0
 	github.com/spf13/pflag v1.0.5

go.sum

@@ -490,8 +490,8 @@ github.com/rogpeppe/go-internal v1.11.0 h1:cWPaGQEPrBb5/AsnsZesgZZ9yb1OQ+GOISoDN
 github.com/russross/blackfriday/v2 v2.1.0/go.mod h1:+Rmxgy9KzJVeS9/2gXHxylqXiyQDYRxCVz55jmeOWTM=
 github.com/sabhiram/go-gitignore v0.0.0-20210923224102-525f6e181f06 h1:OkMGxebDjyw0ULyrTYWeN0UNCCkmCWfjPnIA2W6oviI=
 github.com/sabhiram/go-gitignore v0.0.0-20210923224102-525f6e181f06/go.mod h1:+ePHsJ1keEjQtpvf9HHw0f4ZeJ0TLRsxhunSI2hYJSs=
-github.com/scaleway/scaleway-sdk-go v1.0.0-beta.21.0.20231110143144-15d133efb1a7 h1:4q9+x0UOZj3vr+KyJb3tmH8O40IumJLzWTCLjk2a1f0=
-github.com/scaleway/scaleway-sdk-go v1.0.0-beta.21.0.20231110143144-15d133efb1a7/go.mod h1:fCa7OJZ/9DRTnOKmxvT6pn+LPWUptQAmHF/SBJUGEcg=
+github.com/scaleway/scaleway-sdk-go v1.0.0-beta.21.0.20231113154526-f7d9669f9369 h1:EmtsNvuv6ID2Mtj0rn7ed+uxNMiPjbOkinCWJi8d7IM=
+github.com/scaleway/scaleway-sdk-go v1.0.0-beta.21.0.20231113154526-f7d9669f9369/go.mod h1:fCa7OJZ/9DRTnOKmxvT6pn+LPWUptQAmHF/SBJUGEcg=
 github.com/sclevine/spec v1.4.0 h1:z/Q9idDcay5m5irkZ28M7PtQM4aOISzOpj4bUPkDee8=
 github.com/secure-systems-lab/go-securesystemslib v0.4.0 h1:b23VGrQhTA8cN2CbBw7/FulN9fTtqYUdS5+Oxzt+DUE=
 github.com/sergi/go-diff v1.0.0/go.mod h1:0CfEIISq7TuYL3j771MWULgwwjU+GofnZX9QAmXWZgo=

internal/namespaces/instance/v1/instance_cli.go

@@ -1719,7 +1719,7 @@ func instanceVolumeCreate() *core.Command {
 				Name:       "base-volume",
 				Short:      `ID of the volume on which this volume will be based`,
 				Required:   false,
-				Deprecated: false,
+				Deprecated: true,
 				Positional: false,
 			},
 			{