Skip to content

Commit 056c7c2

Browse files
authored
chore(k8s): deprecate replace on DeleteNode (#5377)
1 parent 79c696a commit 056c7c2

File tree

3 files changed

+0
-21
lines changed

3 files changed

+0
-21
lines changed

cmd/scw/testdata/test-all-usage-k8s-node-delete-usage.golden

Lines changed: 0 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -12,13 +12,9 @@ EXAMPLES:
1212
Delete a node without evicting workloads
1313
scw k8s node delete 11111111-1111-1111-1111-111111111111 skip-drain=true
1414

15-
Replace a node by a new one
16-
scw k8s node delete 11111111-1111-1111-1111-111111111111 replace=true
17-
1815
ARGS:
1916
node-id ID of the node to replace
2017
[skip-drain] Skip draining node from its workload (Note: this parameter is currently inactive)
21-
[replace] Add a new node after the deletion of this node
2218
[region=fr-par] Region to target. If none is passed will use default region from the config (fr-par | nl-ams | pl-waw)
2319

2420
FLAGS:

docs/commands/k8s.md

Lines changed: 0 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -767,7 +767,6 @@ scw k8s node delete <node-id ...> [arg=value ...]
767767
|------|---|-------------|
768768
| node-id | Required | ID of the node to replace |
769769
| skip-drain | | Skip draining node from its workload (Note: this parameter is currently inactive) |
770-
| replace | | Add a new node after the deletion of this node |
771770
| region | Default: `fr-par`<br />One of: `fr-par`, `nl-ams`, `pl-waw` | Region to target. If none is passed will use default region from the config |
772771

773772

@@ -784,11 +783,6 @@ Delete a node without evicting workloads
784783
scw k8s node delete 11111111-1111-1111-1111-111111111111 skip-drain=true
785784
```
786785

787-
Replace a node by a new one
788-
```
789-
scw k8s node delete 11111111-1111-1111-1111-111111111111 replace=true
790-
```
791-
792786

793787

794788

internal/namespaces/k8s/v1/k8s_cli.go

Lines changed: 0 additions & 11 deletions
Original file line numberDiff line numberDiff line change
@@ -2515,13 +2515,6 @@ func k8sNodeDelete() *core.Command {
25152515
Deprecated: false,
25162516
Positional: false,
25172517
},
2518-
{
2519-
Name: "replace",
2520-
Short: `Add a new node after the deletion of this node`,
2521-
Required: false,
2522-
Deprecated: false,
2523-
Positional: false,
2524-
},
25252518
core.RegionArgSpec(
25262519
scw.RegionFrPar,
25272520
scw.RegionNlAms,
@@ -2545,10 +2538,6 @@ func k8sNodeDelete() *core.Command {
25452538
Short: "Delete a node without evicting workloads",
25462539
Raw: `scw k8s node delete 11111111-1111-1111-1111-111111111111 skip-drain=true`,
25472540
},
2548-
{
2549-
Short: "Replace a node by a new one",
2550-
Raw: `scw k8s node delete 11111111-1111-1111-1111-111111111111 replace=true`,
2551-
},
25522541
},
25532542
}
25542543
}

0 commit comments

Comments
 (0)