Review changes

Author: szymon-rd

compiler/src/dotty/tools/dotc/reporting/Reporter.scala

@@ -209,9 +209,9 @@ abstract class Reporter extends interfaces.ReporterResult {
   def incomplete(dia: Diagnostic)(using Context): Unit =
     incompleteHandler(dia, ctx)
 
-  def finalizeReporting()(using Context) = 
+  def finalizeReporting()(using Context) =
     if (hasWarnings && ctx.settings.XfatalWarnings.value)
-      report(new Error("No warnings can be incurred under -Werror.", NoSourcePosition))
+      report(new Error("No warnings can be incurred under -Werror (or -Xfatal-warnings)", NoSourcePosition))
 
   /** Summary of warnings and errors */
   def summary: String = {

compiler/test-resources/repl/rewrite-messages

@@ -4,7 +4,7 @@ scala> import scala.util._
 1 | import scala.util._
   |                   ^
   |         `_` is no longer supported for a wildcard import; use `*` instead
-No warnings can be incurred under -Werror.
+No warnings can be incurred under -Werror (or -Xfatal-warnings)
 1 warning found
 1 error found
 scala> extension (x: Int) def foo(y: Int) = x + y
@@ -15,6 +15,6 @@ scala> 2 foo 4
   |   ^^^
   |Alphanumeric method foo is not declared infix; it should not be used as infix operator.
   |Instead, use method syntax .foo(...) or backticked identifier `foo`.
-No warnings can be incurred under -Werror.
+No warnings can be incurred under -Werror (or -Xfatal-warnings)
 1 warning found
 1 error found

compiler/test/dotty/tools/dotc/CompilationTests.scala

@@ -215,9 +215,8 @@ class CompilationTests {
   // initialization tests
   @Test def checkInitGlobal: Unit = {
     implicit val testGroup: TestGroup = TestGroup("checkInitGlobal")
-    val options = defaultOptions.and("-Ysafe-init-global", "-Xfatal-warnings")
     compileFilesInDir("tests/init-global/warn", defaultOptions.and("-Ysafe-init-global"), FileFilter.exclude(TestSources.negInitGlobalScala2LibraryTastyBlacklisted)).checkWarnings()
-    compileFilesInDir("tests/init-global/pos", options, FileFilter.exclude(TestSources.posInitGlobalScala2LibraryTastyBlacklisted)).checkCompile()
+    compileFilesInDir("tests/init-global/pos", defaultOptions.and("-Ysafe-init-global", "-Xfatal-warnings"), FileFilter.exclude(TestSources.posInitGlobalScala2LibraryTastyBlacklisted)).checkCompile()
   }
 
   // initialization tests

tests/neg-custom-args/sourcepath2/hi/A.check

@@ -4,4 +4,4 @@
   |      class Hello is in the wrong directory.
   |      It was declared to be in package <empty>
   |      But it is found in directory     hi
-No warnings can be incurred under -Werror.
+No warnings can be incurred under -Werror (or -Xfatal-warnings)

tests/neg-macros/i9570.check

@@ -2,4 +2,4 @@
 15 |        case '{HCons(_,$t)} => // warn (in .check file)
    |                     ^
    |             Use of `_` for lambda in quoted pattern. Use explicit lambda instead or use `$_` to match any term.
-No warnings can be incurred under -Werror.
+No warnings can be incurred under -Werror (or -Xfatal-warnings)

tests/neg-macros/i9570.scala

@@ -20,9 +20,9 @@ object Macros {
 
     inline def size(inline expr: HList ): Int = {
       ${sizeImpl('expr,0)}
-    } 
+    }
 
   }
 }
 
-// nopos-error No warnings can be incurred under -Werror.
+// nopos-error No warnings can be incurred under -Werror (or -Xfatal-warnings)

tests/neg-macros/macro-deprecation.check

@@ -2,4 +2,4 @@
 5 |inline def f = ${ impl } // warn (in .check file)
   |                  ^^^^
   |                  method impl is deprecated
-No warnings can be incurred under -Werror.
+No warnings can be incurred under -Werror (or -Xfatal-warnings)

tests/neg-macros/macro-deprecation.scala

@@ -5,4 +5,4 @@ import scala.quoted.*
 inline def f = ${ impl } // warn (in .check file)
 @deprecated def impl(using Quotes) = '{1}
 
-// nopos-error No warnings can be incurred under -Werror.
+// nopos-error No warnings can be incurred under -Werror (or -Xfatal-warnings)

tests/neg-scalajs/enumeration-warnings.check

@@ -58,4 +58,4 @@
    |                               ^^^^^^^^^^^^
    |                 Passing null as name to a constructor of scala.Enumeration.Val requires reflection at run-time.
    |                 The resulting program is unlikely to function properly.
-No warnings can be incurred under -Werror.
+No warnings can be incurred under -Werror (or -Xfatal-warnings)

tests/neg-scalajs/enumeration-warnings.scala

@@ -36,4 +36,4 @@ class ExtendsValWithNullName extends Enumeration {
   protected class Val2 extends Val(1, null) // warn
 }
 
-// nopos-error: No warnings can be incurred under -Werror.
+// nopos-error: No warnings can be incurred under -Werror (or -Xfatal-warnings)