Skip to content

Commit 2043859

Browse files
authored
fix(overlay-services): weaken close event type (#308)
1 parent dc6f8a4 commit 2043859

File tree

2 files changed

+6
-2
lines changed

2 files changed

+6
-2
lines changed

src/angular/dialog/dialog/dialog-service.ts

Lines changed: 3 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -16,7 +16,9 @@ export class SbbDialogService extends SbbOverlayBaseService<
1616
protected containerType = SbbDialogContainer;
1717
protected overlayRefConstructor = SbbDialogRef;
1818

19-
public override open<T = unknown, R = unknown>(
19+
// TODO(breaking-change): The default type for R should be `unknown`.
20+
// eslint-disable-next-line @typescript-eslint/no-explicit-any
21+
public override open<T = unknown, R = any>(
2022
componentOrTemplateRef: ComponentType<T> | TemplateRef<T>,
2123
config?: SbbOverlayConfig<SbbDialogContainer, SbbDialog>,
2224
): SbbDialogRef<T, R> {

src/angular/overlay/overlay-service.ts

Lines changed: 3 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -16,7 +16,9 @@ export class SbbOverlayService extends SbbOverlayBaseService<
1616
protected containerType = SbbOverlayContainer;
1717
protected overlayRefConstructor = SbbOverlayRef;
1818

19-
public override open<T = unknown, R = unknown>(
19+
// TODO(breaking-change): The default type for R should be `unknown`.
20+
// eslint-disable-next-line @typescript-eslint/no-explicit-any
21+
public override open<T = unknown, R = any>(
2022
componentOrTemplateRef: ComponentType<T> | TemplateRef<T>,
2123
config?: SbbOverlayConfig<SbbOverlayContainer, SbbOverlay>,
2224
): SbbOverlayRef<T, R> {

0 commit comments

Comments
 (0)