Skip to content
This repository was archived by the owner on May 31, 2020. It is now read-only.
This repository was archived by the owner on May 31, 2020. It is now read-only.

Plugin moves wrong files #25

@mried

Description

@mried

Hi!

I found a strange behaviour while using copyartifacts. Imagine the following situation before importing:

library/title.mp3
library/artist/track1.mp3
library/artist/track2.mp3
library/artist/track3.mp3
library/artist/cover.jpg

The paths are configured such singletons are moved into a folder called misc at the library root hence the title.mp3 will be moved while importing. Doing so leads to the following situation:

library/artist/track1.mp3
library/artist/track2.mp3
library/artist/track3.mp3
library/misc/title.mp3
library/misc/artist/cover.jpg

So the cover gets moved into the misc folder, too.

After digging a bit through the code I found the reason for this behaviour: It searches recursively for files to move. Since title.mp3 is moved, the plugin finds cover.jpg in the sub folder.

I'm not sure if this will only happen for my special situation here or if it might bite others, too. I'm also unsure how to solve this. Basically, I see two possibilities:

  1. Add a config option to turn off recursive search.
  2. Only search recursively until there is a file which might be handled by beets inside the child folders.

Any thoughts about it?

Metadata

Metadata

Assignees

No one assigned

    Labels

    Projects

    No projects

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions