Skip to content

Commit 1278d69

Browse files
committed
test(wtr): clean up options
1 parent e1b5f94 commit 1278d69

File tree

2 files changed

+17
-17
lines changed

2 files changed

+17
-17
lines changed

packages/@lwc/integration-not-karma/helpers/options.mjs

Lines changed: 11 additions & 10 deletions
Original file line numberDiff line numberDiff line change
@@ -41,18 +41,10 @@ export const API_VERSION = process.env.API_VERSION
4141
: HIGHEST_API_VERSION;
4242

4343
export const NODE_ENV_FOR_TEST = process.env.NODE_ENV_FOR_TEST;
44-
export const GREP = process.env.GREP;
45-
46-
// --- CI config --- //
4744

48-
export const COVERAGE = Boolean(process.env.COVERAGE);
49-
export const SAUCE_USERNAME = process.env.SAUCE_USERNAME;
50-
export const SAUCE_ACCESS_KEY = process.env.SAUCE_ACCESS_KEY || process.env.SAUCE_KEY;
51-
export const SAUCE_TUNNEL_ID = process.env.SAUCE_TUNNEL_ID;
52-
export const IS_CI = Boolean(process.env.IS_CI);
53-
export const GITHUB_RUN_ID = process.env.GITHUB_RUN_ID;
45+
export const GREP = process.env.GREP;
5446

55-
// --- Derivative values --- //
47+
export const NATIVE_SHADOW = DISABLE_SYNTHETIC || FORCE_NATIVE_SHADOW_MODE_FOR_TEST;
5648

5749
/** Unique directory name that encodes the flags that the tests were executed with. */
5850
export const COVERAGE_DIR_FOR_OPTIONS =
@@ -72,3 +64,12 @@ export const COVERAGE_DIR_FOR_OPTIONS =
7264
.filter(([, val]) => val)
7365
.map(([key, val]) => `${key}=${val}`)
7466
.join('/') || 'no-options';
67+
68+
// --- CI config --- //
69+
70+
export const COVERAGE = Boolean(process.env.COVERAGE);
71+
export const SAUCE_USERNAME = process.env.SAUCE_USERNAME;
72+
export const SAUCE_ACCESS_KEY = process.env.SAUCE_ACCESS_KEY || process.env.SAUCE_KEY;
73+
export const SAUCE_TUNNEL_ID = process.env.SAUCE_TUNNEL_ID;
74+
export const IS_CI = Boolean(process.env.IS_CI);
75+
export const GITHUB_RUN_ID = process.env.GITHUB_RUN_ID;

packages/@lwc/integration-not-karma/web-test-runner.config.mjs

Lines changed: 6 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -1,24 +1,23 @@
1-
import { HIGHEST_API_VERSION, LWC_VERSION } from '@lwc/shared';
1+
import { LWC_VERSION } from '@lwc/shared';
22
import customRollup from './helpers/lwc.mjs';
3+
import * as options from './helpers/options.mjs';
34

45
const pluck = (obj, keys) => Object.fromEntries(keys.map((k) => [k, Boolean(obj[k])]));
56

67
const env = {
7-
...pluck(process.env, [
8+
...pluck(options, [
9+
'API_VERSION',
810
'DISABLE_NATIVE_CUSTOM_ELEMENT_LIFECYCLE',
911
'DISABLE_STATIC_CONTENT_OPTIMIZATION',
1012
'DISABLE_SYNTHETIC',
1113
'ENABLE_ARIA_REFLECTION_GLOBAL_POLYFILL',
1214
'ENABLE_SYNTHETIC_SHADOW_IN_HYDRATION',
1315
'ENGINE_SERVER',
1416
'FORCE_NATIVE_SHADOW_MODE_FOR_TEST',
17+
'NATIVE_SHADOW',
1518
]),
16-
API_VERSION: Number(process.env.API_VERSION) || HIGHEST_API_VERSION,
1719
LWC_VERSION,
18-
NATIVE_SHADOW: Boolean(
19-
process.env.DISABLE_SYNTHETIC || process.env.FORCE_NATIVE_SHADOW_MODE_FOR_TEST
20-
),
21-
NODE_ENV: process.env.NODE_ENV_FOR_TEST || 'development',
20+
NODE_ENV: options.NODE_ENV_FOR_TEST || 'development',
2221
};
2322

2423
/** @type {import("@web/test-runner").TestRunnerConfig} */

0 commit comments

Comments
 (0)