Skip to content

Commit 2abfc6b

Browse files
committed
Fixed TLS when InsecureSkipVerify = false
1 parent 1804639 commit 2abfc6b

2 files changed

Lines changed: 17 additions & 9 deletions

File tree

config/config.go

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -67,7 +67,7 @@ type SMTPConfig struct {
6767
URL string
6868
User string
6969
Pass string
70-
TLS TLSConfig
70+
TLS *TLSConfig
7171
}
7272

7373
type TLSConfig struct {

mail/sender.go

Lines changed: 16 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -183,6 +183,9 @@ func (d *deliverer) configureSender() (sender gomail.SendCloser, err error) {
183183
fmt.Println("Retrying SMTP dial on error: ", err)
184184
}),
185185
)
186+
if err != nil {
187+
return nil, err
188+
}
186189
}
187190

188191
// DKIM-signing sender, if configuration is present
@@ -240,15 +243,20 @@ func smtpDialer(cfg *config.SMTPConfig) (*gomail.Dialer, error) {
240243
// Initialize the dialer
241244
d := gomail.NewDialer(surl.Hostname(), port, user, pass)
242245
d.SSL = (surl.Scheme == "smtps")
243-
// insecure TLSConfig
244-
tlsMinVersion, err := cfg.TLS.GetMinVersion()
245-
if err != nil {
246-
return nil, err
247-
}
248-
d.TLSConfig = &tls.Config{
249-
InsecureSkipVerify: cfg.TLS.InsecureSkipVerify,
250-
MinVersion: tlsMinVersion,
246+
247+
// Custom TLSConfig
248+
if cfg.TLS != nil {
249+
tlsMinVersion, err := cfg.TLS.GetMinVersion()
250+
if err != nil {
251+
return nil, err
252+
}
253+
d.TLSConfig = &tls.Config{
254+
InsecureSkipVerify: cfg.TLS.InsecureSkipVerify,
255+
MinVersion: tlsMinVersion,
256+
ServerName: d.Host,
257+
}
251258
}
259+
252260
return d, nil
253261
}
254262

0 commit comments

Comments
 (0)