Skip to content

Commit 608a819

Browse files
committed
fixup! Fix optional arguments in TypeScript
Update tests
1 parent d9c559f commit 608a819

File tree

2 files changed

+11
-2
lines changed

2 files changed

+11
-2
lines changed
Lines changed: 9 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,14 @@
11
use wasm_bindgen::prelude::*;
22

33
#[wasm_bindgen]
4-
pub fn opt_fn(_a: Option<i32>) -> Option<i32> {
4+
/// Optional parameters followed by non-optional parameters.
5+
/// Only the parameter _c may be marked as omittable.
6+
pub fn opt_fn_mixed(_a: Option<i32>, _b: i32, _c: Option<i32>) -> Option<i32> {
7+
None
8+
}
9+
10+
#[wasm_bindgen]
11+
/// Only optional parameters. All of them may be marked as omittable.
12+
pub fn opt_fn_only(_a: Option<i32>, _b: Option<i32>, _c: Option<i32>) -> Option<i32> {
513
None
614
}
Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,3 +1,4 @@
11
import * as wbg from '../pkg/typescript_tests';
22

3-
const opt_fn: (a?: number) => number | undefined = wbg.opt_fn;
3+
const opt_fn_mixed: (a: number | undefined, b: number, c?: number) => number | undefined = wbg.opt_fn_mixed;
4+
const opt_fn_only: (a?: number, b?: number, c?: number) => number | undefined = wbg.opt_fn_only;

0 commit comments

Comments
 (0)