Skip to content

Fix error message of is_*_feature_detected on nort_feature #1232

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Oct 16, 2021
Merged

Fix error message of is_*_feature_detected on nort_feature #1232

merged 1 commit into from
Oct 16, 2021

Conversation

taiki-e
Copy link
Member

@taiki-e taiki-e commented Oct 16, 2021 •
edited
Loading

In the current master, when the feature that cannot be detected at run-time is specified, "nort_feature feature" is mentioned instead of the specified feature name.

Code:

#![feature(stdsimd, arm_target_feature)]

fn f() {
    let _ = is_arm_feature_detected!("v7");
}

Command:

cross build --target arm-unknown-linux-gnueabi

Error(master):

error: nort_feature feature cannot be detected at run-time

Error(this PR):

error: "v7" feature cannot be detected at run-time

@rust-highfive
Copy link

r? @Amanieu

(rust-highfive has picked a reviewer for you, use r? to override)

@Amanieu Amanieu merged commit e95bdf1 into rust-lang:master Oct 16, 2021
@taiki-e taiki-e deleted the error branch October 16, 2021 21:32
@ehuss ehuss mentioned this pull request Nov 13, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@Amanieu Amanieu

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@taiki-e @rust-highfive @Amanieu