Skip to content

Commit 4700e79

Browse files
KobzolKobzol
authored
Merge pull request #2219 from Kobzol/triage-2025-08-12
Add 2025-08-12 triage
2 parents 9ba670f + bd5a0ab commit 4700e79

File tree

1 file changed

+193
-0
lines changed

1 file changed

+193
-0
lines changed

‎triage/2025/2025-08-12.md

Lines changed: 193 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,193 @@
1+
# 2025-08-12 Triage Log
2+
3+
This week saw almost no regressions, while we got some nice wins. One of them was [#143684](https://github.com/rust-lang/rust/pull/143684), which updated the LLVM version used by the Rust compiler to 21.
4+
5+
Triage done by **@kobzol**.
6+
Revision range: [07b7dc90..6355cd39](https://perf.rust-lang.org/?start=07b7dc90ee4df5815dbb91ef8e98cb93571230f5&end=6355cd39c81e9699b1925c58d2ed3165bcab1715&absolute=false&stat=instructions%3Au)
7+
8+
**Summary**:
9+
10+
| (instructions:u) | mean | range | count |
11+
|:----------------------------------:|:-----:|:---------------:|:-----:|
12+
| Regressions ❌ <br /> (primary) | 0.5% | [0.2%, 0.8%] | 3 |
13+
| Regressions ❌ <br /> (secondary) | 0.7% | [0.1%, 1.5%] | 8 |
14+
| Improvements ✅ <br /> (primary) | -1.5% | [-22.8%, -0.2%] | 219 |
15+
| Improvements ✅ <br /> (secondary) | -2.9% | [-18.8%, -0.1%] | 256 |
16+
| All ❌✅ (primary) | -1.5% | [-22.8%, 0.8%] | 222 |
17+
18+
19+
2 Regressions, 2 Improvements, 9 Mixed; 5 of them in rollups
20+
37 artifact comparisons made in total
21+
22+
#### Regressions
23+
24+
Revert #143906 [#145116](https://github.com/rust-lang/rust/pull/145116) [(Comparison Link)](https://perf.rust-lang.org/compare.html?start=2886b36df4a646dd8d82fb65bf0c9d8d96c1f71a&end=de3efa79f95852c7427587f1d535bfea7c0d6779&stat=instructions:u)
25+
26+
| (instructions:u) | mean | range | count |
27+
|:----------------------------------:|:----:|:------------:|:-----:|
28+
| Regressions ❌ <br /> (primary) | - | - | 0 |
29+
| Regressions ❌ <br /> (secondary) | 0.4% | [0.2%, 0.6%] | 10 |
30+
| Improvements ✅ <br /> (primary) | - | - | 0 |
31+
| Improvements ✅ <br /> (secondary) | - | - | 0 |
32+
| All ❌✅ (primary) | - | - | 0 |
33+
34+
- The tiny regressions were noise.
35+
- Marked as triaged.
36+
37+
Rollup of 7 pull requests [#145236](https://github.com/rust-lang/rust/pull/145236) [(Comparison Link)](https://perf.rust-lang.org/compare.html?start=21a19c297d4f5a03501d92ca251bd7a17073c08a&end=53af067bb0b4edf9b5394e5f9b60942974b9fbc2&stat=instructions:u)
38+
39+
| (instructions:u) | mean | range | count |
40+
|:----------------------------------:|:----:|:------------:|:-----:|
41+
| Regressions ❌ <br /> (primary) | 0.3% | [0.2%, 0.5%] | 6 |
42+
| Regressions ❌ <br /> (secondary) | 0.4% | [0.1%, 0.5%] | 17 |
43+
| Improvements ✅ <br /> (primary) | - | - | 0 |
44+
| Improvements ✅ <br /> (secondary) | - | - | 0 |
45+
| All ❌✅ (primary) | 0.3% | [0.2%, 0.5%] | 6 |
46+
47+
- Tiny doc-only regressions caused by adding more const to the standard library.
48+
- Marked as triaged.
49+
50+
#### Improvements
51+
52+
Simplify dead code lint [#144863](https://github.com/rust-lang/rust/pull/144863) [(Comparison Link)](https://perf.rust-lang.org/compare.html?start=213d946a384b46989f6fd9c8ae9c547b4e354455&end=ec7c02612527d185c379900b613311bc1dcbf7dc&stat=instructions:u)
53+
54+
| (instructions:u) | mean | range | count |
55+
|:----------------------------------:|:-----:|:--------------:|:-----:|
56+
| Regressions ❌ <br /> (primary) | - | - | 0 |
57+
| Regressions ❌ <br /> (secondary) | 0.0% | [0.0%, 0.0%] | 1 |
58+
| Improvements ✅ <br /> (primary) | -0.5% | [-1.5%, -0.1%] | 82 |
59+
| Improvements ✅ <br /> (secondary) | -0.3% | [-0.6%, -0.1%] | 12 |
60+
| All ❌✅ (primary) | -0.5% | [-1.5%, -0.1%] | 82 |
61+
62+
63+
Implement `stability_implications` without a visitor. [#144873](https://github.com/rust-lang/rust/pull/144873) [(Comparison Link)](https://perf.rust-lang.org/compare.html?start=915a766b2f9fd53a8cd7b1fad003d3f8e488ff4b&end=8712e4567551a2714efa66dac204ec7137bc5605&stat=instructions:u)
64+
65+
| (instructions:u) | mean | range | count |
66+
|:----------------------------------:|:-----:|:--------------:|:-----:|
67+
| Regressions ❌ <br /> (primary) | - | - | 0 |
68+
| Regressions ❌ <br /> (secondary) | - | - | 0 |
69+
| Improvements ✅ <br /> (primary) | -0.3% | [-0.3%, -0.1%] | 41 |
70+
| Improvements ✅ <br /> (secondary) | -0.9% | [-3.0%, -0.2%] | 26 |
71+
| All ❌✅ (primary) | -0.3% | [-0.3%, -0.1%] | 41 |
72+
73+
74+
#### Mixed
75+
76+
Update to LLVM 21 [#143684](https://github.com/rust-lang/rust/pull/143684) [(Comparison Link)](https://perf.rust-lang.org/compare.html?start=ec7c02612527d185c379900b613311bc1dcbf7dc&end=dc0bae1db725fbba8524f195f74f680995fd549e&stat=instructions:u)
77+
78+
| (instructions:u) | mean | range | count |
79+
|:----------------------------------:|:-----:|:---------------:|:-----:|
80+
| Regressions ❌ <br /> (primary) | 0.5% | [0.2%, 0.9%] | 5 |
81+
| Regressions ❌ <br /> (secondary) | 1.3% | [0.4%, 1.8%] | 19 |
82+
| Improvements ✅ <br /> (primary) | -1.3% | [-23.1%, -0.2%] | 216 |
83+
| Improvements ✅ <br /> (secondary) | -2.7% | [-19.0%, -0.1%] | 266 |
84+
| All ❌✅ (primary) | -1.3% | [-23.1%, 0.9%] | 221 |
85+
86+
- Improvements outweigh the regressions.
87+
- Marked as triaged.
88+
89+
Preserve the .debug_gdb_scripts section [#143679](https://github.com/rust-lang/rust/pull/143679) [(Comparison Link)](https://perf.rust-lang.org/compare.html?start=dc0bae1db725fbba8524f195f74f680995fd549e&end=8fb40f798a23adf608182ce5f4eb151fdc8e0da5&stat=instructions:u)
90+
91+
| (instructions:u) | mean | range | count |
92+
|:----------------------------------:|:------:|:---------------:|:-----:|
93+
| Regressions ❌ <br /> (primary) | 103.7% | [55.2%, 152.2%] | 2 |
94+
| Regressions ❌ <br /> (secondary) | 0.5% | [0.5%, 0.6%] | 3 |
95+
| Improvements ✅ <br /> (primary) | - | - | 0 |
96+
| Improvements ✅ <br /> (secondary) | -1.8% | [-4.6%, -0.0%] | 6 |
97+
| All ❌✅ (primary) | 103.7% | [55.2%, 152.2%] | 2 |
98+
99+
- This change probably caused some incremental query invalidations.
100+
- It was reverted in [#145014](https://github.com/rust-lang/rust/pull/145014).
101+
- Marked as triaged.
102+
103+
Rollup of 15 pull requests [#145020](https://github.com/rust-lang/rust/pull/145020) [(Comparison Link)](https://perf.rust-lang.org/compare.html?start=7d82b83ed57d188ab3f2441a765a6419685a88a3&end=6bcdcc73bd11568fd85f5a38b58e1eda054ad1cd&stat=instructions:u)
104+
105+
| (instructions:u) | mean | range | count |
106+
|:----------------------------------:|:-----:|:--------------:|:-----:|
107+
| Regressions ❌ <br /> (primary) | 0.2% | [0.1%, 0.2%] | 2 |
108+
| Regressions ❌ <br /> (secondary) | 0.3% | [0.1%, 0.7%] | 4 |
109+
| Improvements ✅ <br /> (primary) | - | - | 0 |
110+
| Improvements ✅ <br /> (secondary) | -0.0% | [-0.0%, -0.0%] | 1 |
111+
| All ❌✅ (primary) | 0.2% | [0.1%, 0.2%] | 2 |
112+
113+
- The regression is genuine, but so small that it doesn't seem worth it to investigate it further.
114+
- Marked as triaged.
115+
116+
Revert "Preserve the .debug_gdb_scripts section" [#145014](https://github.com/rust-lang/rust/pull/145014) [(Comparison Link)](https://perf.rust-lang.org/compare.html?start=61cb1e97fcf954c37d0a457a8084ed9ad8b3cb82&end=9b1a30e5e69e1537ef6eb6eb829eb47075206dea&stat=instructions:u)
117+
118+
| (instructions:u) | mean | range | count |
119+
|:----------------------------------:|:------:|:----------------:|:-----:|
120+
| Regressions ❌ <br /> (primary) | - | - | 0 |
121+
| Regressions ❌ <br /> (secondary) | 2.8% | [0.6%, 4.8%] | 4 |
122+
| Improvements ✅ <br /> (primary) | -48.0% | [-60.4%, -35.6%] | 2 |
123+
| Improvements ✅ <br /> (secondary) | -0.5% | [-0.5%, -0.5%] | 3 |
124+
| All ❌✅ (primary) | -48.0% | [-60.4%, -35.6%] | 2 |
125+
126+
- Revert of [#143679](https://github.com/rust-lang/rust/pull/143679).
127+
- Marked as triaged.
128+
129+
Rollup of 19 pull requests [#145043](https://github.com/rust-lang/rust/pull/145043) [(Comparison Link)](https://perf.rust-lang.org/compare.html?start=cd434309efcf5dc68b253e5ef6ba40c1c43711c9&end=321a89bec57b8ca723d1af8f784490b950458c6a&stat=instructions:u)
130+
131+
| (instructions:u) | mean | range | count |
132+
|:----------------------------------:|:-----:|:--------------:|:-----:|
133+
| Regressions ❌ <br /> (primary) | 0.4% | [0.2%, 0.5%] | 4 |
134+
| Regressions ❌ <br /> (secondary) | 0.3% | [0.1%, 0.5%] | 8 |
135+
| Improvements ✅ <br /> (primary) | - | - | 0 |
136+
| Improvements ✅ <br /> (secondary) | -0.3% | [-0.3%, -0.3%] | 2 |
137+
| All ❌✅ (primary) | 0.4% | [0.2%, 0.5%] | 4 |
138+
139+
- The regressions look genuine, but also are tiny.
140+
- Marked as triaged.
141+
142+
Rollup of 9 pull requests [#145074](https://github.com/rust-lang/rust/pull/145074) [(Comparison Link)](https://perf.rust-lang.org/compare.html?start=a980cd4311ae4b5bf9099d418e32643d068f1344&end=67d45f49e09cb8f355df2ffae22cfc3d7ee6c278&stat=instructions:u)
143+
144+
| (instructions:u) | mean | range | count |
145+
|:----------------------------------:|:-----:|:--------------:|:-----:|
146+
| Regressions ❌ <br /> (primary) | 0.8% | [0.1%, 4.3%] | 126 |
147+
| Regressions ❌ <br /> (secondary) | 0.6% | [0.1%, 1.5%] | 39 |
148+
| Improvements ✅ <br /> (primary) | - | - | 0 |
149+
| Improvements ✅ <br /> (secondary) | -1.8% | [-2.9%, -0.1%] | 9 |
150+
| All ❌✅ (primary) | 0.8% | [0.1%, 4.3%] | 126 |
151+
152+
- The regression was caused by [#144857](https://github.com/rust-lang/rust/pull/144857).
153+
- The mentioned PR was reverted in [#145086](https://github.com/rust-lang/rust/pull/145086).
154+
- Marked as triaged.
155+
156+
Rollup of 19 pull requests [#145077](https://github.com/rust-lang/rust/pull/145077) [(Comparison Link)](https://perf.rust-lang.org/compare.html?start=67d45f49e09cb8f355df2ffae22cfc3d7ee6c278&end=2886b36df4a646dd8d82fb65bf0c9d8d96c1f71a&stat=instructions:u)
157+
158+
| (instructions:u) | mean | range | count |
159+
|:----------------------------------:|:-----:|:--------------:|:-----:|
160+
| Regressions ❌ <br /> (primary) | - | - | 0 |
161+
| Regressions ❌ <br /> (secondary) | 0.1% | [0.1%, 0.1%] | 3 |
162+
| Improvements ✅ <br /> (primary) | -1.0% | [-1.0%, -1.0%] | 1 |
163+
| Improvements ✅ <br /> (secondary) | -0.4% | [-0.6%, -0.2%] | 12 |
164+
| All ❌✅ (primary) | -1.0% | [-1.0%, -1.0%] | 1 |
165+
166+
- Some of the improvements were likely noise, but overall it was a wash.
167+
- Marked as triaged.
168+
169+
Revert "Port `#[allow_internal_unsafe]` to the new attribute system" [#145086](https://github.com/rust-lang/rust/pull/145086) [(Comparison Link)](https://perf.rust-lang.org/compare.html?start=ffb9d94dcf4ade0d534842be3672d5e9f47e1333&end=4c7749e8c8e50ad146da599eea3a250160c1bc2b&stat=instructions:u)
170+
171+
| (instructions:u) | mean | range | count |
172+
|:----------------------------------:|:-----:|:--------------:|:-----:|
173+
| Regressions ❌ <br /> (primary) | - | - | 0 |
174+
| Regressions ❌ <br /> (secondary) | 2.8% | [2.6%, 2.9%] | 6 |
175+
| Improvements ✅ <br /> (primary) | -0.8% | [-4.1%, -0.1%] | 121 |
176+
| Improvements ✅ <br /> (secondary) | -0.7% | [-1.4%, -0.1%] | 39 |
177+
| All ❌✅ (primary) | -0.8% | [-4.1%, -0.1%] | 121 |
178+
179+
- Revert of [#144857](https://github.com/rust-lang/rust/pull/144857).
180+
- Marked as triaged.
181+
182+
Stop using uadd.with.overflow [#145144](https://github.com/rust-lang/rust/pull/145144) [(Comparison Link)](https://perf.rust-lang.org/compare.html?start=8712e4567551a2714efa66dac204ec7137bc5605&end=7f7b8ef27d86c865a7ab20c7c42f50811c6a914d&stat=instructions:u)
183+
184+
| (instructions:u) | mean | range | count |
185+
|:----------------------------------:|:-----:|:--------------:|:-----:|
186+
| Regressions ❌ <br /> (primary) | 0.2% | [0.2%, 0.2%] | 1 |
187+
| Regressions ❌ <br /> (secondary) | - | - | 0 |
188+
| Improvements ✅ <br /> (primary) | -0.3% | [-0.3%, -0.2%] | 7 |
189+
| Improvements ✅ <br /> (secondary) | -0.5% | [-0.8%, -0.2%] | 14 |
190+
| All ❌✅ (primary) | -0.2% | [-0.3%, 0.2%] | 8 |
191+
192+
- More improvements than regressions.
193+
- Already marked as triaged.

0 commit comments

Comments
 (0)