Skip to content

Enable check-cfg in stage0 #98843

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Jul 20, 2022
Merged

Enable check-cfg in stage0 #98843

merged 2 commits into from
Jul 20, 2022

Conversation

Urgau
Copy link
Member

@Urgau Urgau commented Jul 3, 2022

Now that the bootstrap cargo supports rustc-check-cfg we can now enable it with -Zcheck-cfg=output and use it in rustc_llvm to unblock --check-cfg support in stage0.

r? @Mark-Simulacrum

@rustbot rustbot added the T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. label Jul 3, 2022
@rust-highfive rust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Jul 3, 2022
@rust-log-analyzer

This comment has been minimized.

Sign in to view
@Urgau Urgau force-pushed the check-cfg-stage0 branch from 4948a6d to 8c7dc55 Compare July 3, 2022 14:02
@rust-log-analyzer

This comment has been minimized.

Sign in to view
@Urgau Urgau force-pushed the check-cfg-stage0 branch from 8c7dc55 to f818872 Compare July 3, 2022 14:17
@Mark-Simulacrum
Copy link
Member

@bors r+ rollup=iffy

@bors
Copy link
Collaborator

bors commented Jul 12, 2022

📌 Commit f818872 has been approved by Mark-Simulacrum

It is now in the queue for this repository.

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Jul 12, 2022
@bors
Copy link
Collaborator

bors commented Jul 13, 2022

⌛ Testing commit f818872 with merge a295195c6f5f6ef10f31145839abbc1f5b360c9c...

@bors bors mentioned this pull request Jul 13, 2022
Merged
@bors
Copy link
Collaborator

bors commented Jul 13, 2022

💔 Test failed - checks-actions

@bors bors added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. labels Jul 13, 2022
@rust-log-analyzer
Copy link
Collaborator

The job x86_64-gnu-aux failed! Check out the build log: (web) (plain)

Click to see the possible cause of the failure (guessed by this bot) 
1   1         Updating [..]
2   2      Downloading crates ...
3   3       Downloaded common v1.0.0 [..]
4   4        Compiling common v1.0.0
5   5          Running `rustc --crate-name common [..]
6        -     Running `rustc --crate-name common [..]
7   6        Compiling pm v0.1.0 [..]
    7    +     Running `rustc --crate-name common /checkout/obj/build/x86_64-unknown-linux-gnu/stage2-tools/x86_64-unknown-linux-gnu/tmp/cit/t767/home/.cargo/registry/src/-4dba4148552fc90b/common-1.0.0/src/lib.rs --error-format=json --json=diagnostic-rendered-ansi,artifacts,future-incompat --crate-type lib --emit=dep-info,metadata,link -C opt-level=2 -C embed-bitcode=no -C debuginfo=2 -C debug-assertions=on -C metadata=3727013b635cbf1c -C extra-filename=-3727013b635cbf1c --out-dir /checkout/obj/build/x86_64-unknown-linux-gnu/stage2-tools/x86_64-unknown-linux-gnu/tmp/cit/t767/foo/target/debug/deps -L dependency=/checkout/obj/build/x86_64-unknown-linux-gnu/stage2-tools/x86_64-unknown-linux-gnu/tmp/cit/t767/foo/target/debug/deps --cap-lints allow`
8   8          Running `rustc --crate-name pm [..]
9   9        Compiling foo v0.1.0 [..]
10  10         Running `rustc --crate-name foo [..]
11  11        Finished [..]

other output:

', src/tools/cargo/tests/testsuite/collisions.rs:372:10
---
test result: FAILED. 2586 passed; 1 failed; 7 ignored; 0 measured; 0 filtered out; finished in 113.71s

error: test failed, to rerun pass '--test testsuite'
Build completed unsuccessfully in 0:31:53
make: *** [check-aux] Error 1
Makefile:44: recipe for target 'check-aux' failed

@Mark-Simulacrum
Copy link
Member

@bors retry

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Jul 14, 2022
@bors
Copy link
Collaborator

bors commented Jul 20, 2022

⌛ Testing commit f818872 with merge 03d488b...

@bors
Copy link
Collaborator

bors commented Jul 20, 2022

☀️ Test successful - checks-actions
Approved by: Mark-Simulacrum
Pushing 03d488b to master...

@bors bors added the merged-by-bors This PR was explicitly merged by bors. label Jul 20, 2022
@bors bors merged commit 03d488b into rust-lang:master Jul 20, 2022
@rustbot rustbot added this to the 1.64.0 milestone Jul 20, 2022
@bors bors mentioned this pull request Jul 20, 2022
Merged
@rust-timer
Copy link
Collaborator

Finished benchmarking commit (03d488b): comparison url.

Instruction count

This benchmark run did not return any relevant results for this metric.

Max RSS (memory usage)

Results
  • Primary benchmarks: no relevant changes found
  • Secondary benchmarks: mixed results
mean1 max count2
Regressions 😿
(primary)		 N/A N/A 0
Regressions 😿
(secondary)		 6.1% 8.9% 3
Improvements 🎉
(primary)		 N/A N/A 0
Improvements 🎉
(secondary)		 -3.0% -3.4% 2
All 😿🎉 (primary) N/A N/A 0

Cycles

Results
  • Primary benchmarks: mixed results
  • Secondary benchmarks: no relevant changes found
mean1 max count2
Regressions 😿
(primary)		 2.3% 2.3% 1
Regressions 😿
(secondary)		 N/A N/A 0
Improvements 🎉
(primary)		 -2.5% -2.5% 1
Improvements 🎉
(secondary)		 N/A N/A 0
All 😿🎉 (primary) -0.1% -2.5% 2

If you disagree with this performance assessment, please file an issue in rust-lang/rustc-perf.

@rustbot label: -perf-regression

Footnotes

  1. the arithmetic mean of the percent change ↩ ↩2

  2. number of relevant changes ↩ ↩2

@Urgau Urgau deleted the check-cfg-stage0 branch May 5, 2023 16:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@Mark-Simulacrum Mark-Simulacrum

Labels
merged-by-bors This PR was explicitly merged by bors. S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue.
Projects
None yet
Milestone
1.64.0
Development

Successfully merging this pull request may close these issues.
7 participants
@Urgau @rust-log-analyzer @Mark-Simulacrum @bors @rust-timer @rust-highfive @rustbot