[bootstrap] Give a better error when trying to run a path with no registered step #96660
+13
−1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
(rust-highfive has picked a reviewer for you, use r? to override) |
rust-highfive
added
the
S-waiting-on-review
…istered step Before: ``` thread 'main' panicked at 'error: no rules matched invalid', src/bootstrap/builder.rs:287:17 note: run with `RUST_BACKTRACE=1` environment variable to display a backtrace ``` After: ``` error: no `check` rules matched 'invalid' help: run `x.py check --help --verbose` to show a list of available paths note: if you are adding a new Step to bootstrap itself, make sure you register it with `describe!` ```
jyn514
force-pushed
the
better-missing-path-error
branch
from
f77a48b to
3a800bf
Compare
| builder.kind.as_str() | ||
| ); | ||
| eprintln!( | ||
| "note: if you are adding a new Step to bootstrap itself, make sure you register it with `describe!`" |
There was a problem hiding this comment.
I think probably we should say something like "in src/bootstrap/builder.rs" here, though I guess it's not that hard to find:
$ rg 'describe!'
src/bootstrap/builder.rs
494: Kind::Build => describe!(
525: Kind::Check => describe!(
536: Kind::Test => describe!(
591: Kind::Bench => describe!(test::Crate, test::CrateLibrustc),
592: Kind::Doc => describe!(
612: Kind::Dist => describe!(
640: Kind::Install => describe!(
654: Kind::Run => describe!(run::ExpandYamlAnchors, run::BuildManifest, run::BumpStage0),
So maybe alright for now, and better short for such a specific message anyway.
|
@bors r+ rollup |
|
📌 Commit 3a800bf has been approved by |
bors
added
S-waiting-on-bors
bors
added a commit
to rust-lang-ci/rust
that referenced
this pull request
May 7, 2022
…piler-errors Rollup of 8 pull requests Successful merges: - rust-lang#96660 ([bootstrap] Give a better error when trying to run a path with no registered step) - rust-lang#96701 (update `jemallocator` example to use 2018 edition import syntax) - rust-lang#96746 (Fix an ICE on rust-lang#96738) - rust-lang#96758 (bootstrap: bsd platform flags for split debuginfo) - rust-lang#96778 (Remove closures on `expect_local` to apply `#[track_caller]`) - rust-lang#96781 (Fix an incorrect link in The Unstable Book) - rust-lang#96783 (Link to correct issue in issue-95034 known-bug) - rust-lang#96801 (Add regression test for rust-lang#96319) Failed merges: r? `@ghost` `@rustbot` modify labels: rollup
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Before:
After: