Skip to content

Add incomplete feature gate for inherent associate types. #82516

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Mar 2, 2021
Merged

Add incomplete feature gate for inherent associate types. #82516

merged 1 commit into from
Mar 2, 2021

Conversation

PoignardAzur
Copy link
Contributor

@PoignardAzur PoignardAzur commented Feb 25, 2021 •
edited
Loading

Mentored by @oli-obk

So far the only change is that instead of giving an automatic error, the following code compiles:

struct Foo;

impl Foo {
    type Bar = isize;
}

The backend work to make it actually usable isn't there yet. In particular, this:

let x : Foo::Bar;

will give you:

error[E0223]: ambiguous associated type
  --> /$RUSTC_DIR/src/test/ui/assoc-inherent.rs:15:13
   |
LL |     let x : Foo::Bar;
   |             ^^^^^^^^ help: use fully-qualified syntax: `<Foo as Trait>::Bar`

@rust-highfive
Copy link
Contributor

Some changes occurred in diagnostic error codes

cc @GuillaumeGomez

@rust-highfive
Copy link
Contributor

r? @davidtwco

(rust-highfive has picked a reviewer for you, use r? to override)

@rust-highfive rust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Feb 25, 2021
@oli-obk
Copy link
Contributor

oli-obk commented Feb 25, 2021

r? @oli-obk

@rust-highfive rust-highfive assigned oli-obk and unassigned davidtwco Feb 25, 2021
@oli-obk
Copy link
Contributor

oli-obk commented Feb 25, 2021

@bors r+

@bors
Copy link
Collaborator

bors commented Feb 25, 2021

📌 Commit 4f4e15d has been approved by oli-obk

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Feb 25, 2021
@oli-obk oli-obk mentioned this pull request Feb 25, 2021
Open
3 tasks
@camelid camelid added the F-inherent_associated_types `#![feature(inherent_associated_types)]` label Feb 26, 2021
@bors
Copy link
Collaborator

bors commented Feb 27, 2021

⌛ Testing commit 4f4e15d with merge 30e2baab56af30b9bd3c453fbc5e209f35ca68d1...

@bors
Copy link
Collaborator

bors commented Feb 27, 2021

💥 Test timed out

@bors bors added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. labels Feb 27, 2021
@rust-log-analyzer
Copy link
Collaborator

A job failed! Check out the build log: (web) (plain)

Click to see the possible cause of the failure (guessed by this bot)

@oli-obk
Copy link
Contributor

oli-obk commented Mar 1, 2021

@bors retry

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Mar 1, 2021
@JohnTitor JohnTitor mentioned this pull request Mar 2, 2021
Merged
bors added a commit to rust-lang-ci/rust that referenced this pull request Mar 2, 2021
@bors
Auto merge of rust-lang#82698 - JohnTitor:rollup-htd533c, r=JohnTitor
67342b8 
Rollup of 10 pull requests

Successful merges:

 - rust-lang#80189 (Convert primitives in the standard library to intra-doc links)
 - rust-lang#80874 (Update intra-doc link documentation to match the implementation)
 - rust-lang#82376 (Add option to enable MIR inlining independently of mir-opt-level)
 - rust-lang#82516 (Add incomplete feature gate for inherent associate types.)
 - rust-lang#82579 (Fix turbofish recovery with multiple generic args)
 - rust-lang#82593 (Teach rustdoc how to display WASI.)
 - rust-lang#82597 (Get TyCtxt from self instead of passing as argument in AutoTraitFinder)
 - rust-lang#82627 (Erase late bound regions to avoid ICE)
 - rust-lang#82661 (:arrow_up: rust-analyzer)
 - rust-lang#82691 (Update books)

Failed merges:

r? `@ghost`
`@rustbot` modify labels: rollup
@bors bors merged commit 5e68c60 into rust-lang:master Mar 2, 2021
@rustbot rustbot added this to the 1.52.0 milestone Mar 2, 2021
@PoignardAzur PoignardAzur deleted the inherent-impl-ty branch March 3, 2021 11:48
@FabianWolff FabianWolff mentioned this pull request May 17, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@oli-obk oli-obk

Labels
F-inherent_associated_types `#![feature(inherent_associated_types)]` S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion.
Projects
Inherent Associated Types (IAT)
Status: Done
Milestone
1.52.0
Development

Successfully merging this pull request may close these issues.
8 participants
@PoignardAzur @rust-highfive @oli-obk @bors @rust-log-analyzer @davidtwco @camelid @rustbot