Rollup of 5 pull requests #80568
Closed
Rollup of 5 pull requests #80568
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
These docs were very out of date and misleading. They even said that they codegen'd the *AST*! For some reason, the `rustc_codegen_ssa::base` docs were exactly identical to the `rustc_codegen_llvm::base` docs. They didn't really make sense, because they had LLVM-specific information even though `rustc_codegen_ssa` is supposed to be somewhat generic. So I removed them as they were misleading.
The command is `@!has`, not `!@has`. I don't think these checks were doing anything before! Ideally we would accept `!@has` as well, or at least fail tests that use `!@has`. The current behavior seems to be silently ignoring the check, which is very confusing.
Update and improve `rustc_codegen_{llvm,ssa}` docs
Fixes rust-lang#75342.
These docs were very out of date and misleading. They even said that
they codegen'd the *AST*!
For some reason, the `rustc_codegen_ssa::base` docs were exactly
identical to the `rustc_codegen_llvm::base` docs. They didn't really
make sense, because they had LLVM-specific information even though
`rustc_codegen_ssa` is supposed to be somewhat generic. So I removed
them as they were misleading.
r? ```@pnkfelix``` maybe?
Take type defaults into account in suggestions to reorder generic parameters Fixes rust-lang#80512
remove unnecessary trailing semicolon from bootstrap
support pattern as const parents in type_of nice to know that there's still stuff about rust i didn't know about 😆 fixes rust-lang#80531 r? ``@varkor``
Fix tests that incorrectly used `!@has` instead of `@!has` The command is ``@!has`,` not `!`@has`.` I don't think these checks were doing anything before! Ideally we would accept `!`@has`` as well, or at least fail tests that use `!`@has`.` The current behavior seems to be silently ignoring the check, which is very confusing. r? `@GuillaumeGomez`
|
@bors: r+ p=5 |
|
📌 Commit e7aeb06 has been approved by |
bors
added
the
S-waiting-on-bors
|
Had a rollup already present but hadn't r+ it :) so closing this. Sorry :D |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Successful merges:
rustc_codegen_{llvm,ssa}docs #80323 (Update and improverustc_codegen_{llvm,ssa}docs)!@hasinstead of@!has#80565 (Fix tests that incorrectly used!@hasinstead of@!has)Failed merges:
r? @ghost
@rustbot modify labels: rollup
Create a similar rollup