Make Ipv4Addr and Ipv6Addr const tests unit tests under library
#76299
Conversation
|
r? @kennytm (rust_highfive has picked a reviewer for you, use r? to override) |
rust-highfive
added
the
S-waiting-on-review
|
Currently implemented as two big tests: |
|
r? @matklad |
|
Rather than adding a new integration test in src/test directory, let’s add the test to existing unit-test module: https://github.com/rust-lang/rust/blob/2906a60a4f6b417abd487f0d8c917532911fdd20/library/std/src/net/ip/tests.rs Integration tests have essentially the same problem as run-pass tests — each integration test is a separately linked and run binary, so many integration tests = slow. |
|
Ah I see, I moved the tests. I still kept the tests as |
|
LGTM! Could you squash the commits to one here as well? @bors delegate=CDirkx |
|
✌️ @CDirkx can now approve this pull request |
These tests are about the standard library, not the compiler itself, thus should live in `library`, see rust-lang#76268.
CDirkx
changed the title
Ipv4Addr and Ipv6Addr const tests to library\std\testsIpv4Addr and Ipv6Addr const tests unit tests under library
|
@bors r+ rollup Thanks! |
|
📌 Commit a2e077e has been approved by |
bors
added
S-waiting-on-bors
jyn514
added
A-testsuite
|
Alright, I'll update the tests in the other PRs similarly |
Make `Ipv4Addr` and `Ipv6Addr` const tests unit tests under `library` These tests are about the standard library, not the compiler itself, thus should live in `library`, see rust-lang#76268.
Make `Ipv4Addr` and `Ipv6Addr` const tests unit tests under `library` These tests are about the standard library, not the compiler itself, thus should live in `library`, see rust-lang#76268.
Make `Ipv4Addr` and `Ipv6Addr` const tests unit tests under `library` These tests are about the standard library, not the compiler itself, thus should live in `library`, see rust-lang#76268.
Make `Ipv4Addr` and `Ipv6Addr` const tests unit tests under `library` These tests are about the standard library, not the compiler itself, thus should live in `library`, see rust-lang#76268.
Make `Ipv4Addr` and `Ipv6Addr` const tests unit tests under `library` These tests are about the standard library, not the compiler itself, thus should live in `library`, see rust-lang#76268.
Make `Ipv4Addr` and `Ipv6Addr` const tests unit tests under `library` These tests are about the standard library, not the compiler itself, thus should live in `library`, see rust-lang#76268.
Rollup of 18 pull requests Successful merges: - rust-lang#76273 (Move some Vec UI tests into alloc unit tests) - rust-lang#76274 (Allow try blocks as the argument to return expressions) - rust-lang#76287 (Remove an unnecessary allowed lint) - rust-lang#76293 (Implementation of incompatible features error) - rust-lang#76299 (Make `Ipv4Addr` and `Ipv6Addr` const tests unit tests under `library`) - rust-lang#76302 (Address review comments on `Peekable::next_if`) - rust-lang#76303 (Link to `#capacity-and-reallocation` when using with_capacity) - rust-lang#76305 (Move various ui const tests to `library`) - rust-lang#76309 (Indent a note to make folding work nicer) - rust-lang#76312 (time.rs: Make spelling of "Darwin" consistent) - rust-lang#76318 (Use ops::ControlFlow in rustc_data_structures::graph::iterate) - rust-lang#76324 (Move Vec slice UI tests in library) - rust-lang#76338 (add some intra-doc links to `Iterator`) - rust-lang#76340 (Remove unused duplicated `trivial_dropck_outlives`) - rust-lang#76344 (Improve docs for `std::env::args()`) - rust-lang#76346 (Docs: nlink example typo) - rust-lang#76358 (Minor grammar fix in doc comment for soft-deprecated methods) - rust-lang#76364 (Disable atomics on avr target.) Failed merges: - rust-lang#76304 (Make delegation methods of `std::net::IpAddr` unstably const) r? @ghost
These tests are about the standard library, not the compiler itself, thus should live in
library, see #76268.