Skip to content

Conversation

tesuji
Copy link
Contributor

@tesuji tesuji commented Jun 16, 2020

Resolve this comment: #73331 (comment)

@rust-highfive rust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Jun 16, 2020
@tesuji tesuji changed the title Use Ipv4Addr::from<[u8; 4] when possible Use Ipv4Addr::from<[u8; 4]> when possible Jun 16, 2020
@kennytm
Copy link
Member

kennytm commented Jun 16, 2020

@bors r+ rollup

@bors
Copy link
Collaborator

bors commented Jun 16, 2020

📌 Commit 0e6c333 has been approved by kennytm

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Jun 16, 2020
Dylan-DPC-zz pushed a commit to Dylan-DPC-zz/rust that referenced this pull request Jun 16, 2020
Use `Ipv4Addr::from<[u8; 4]>` when possible

Resolve this comment: rust-lang#73331 (comment)
This was referenced Jun 16, 2020
bors added a commit to rust-lang-ci/rust that referenced this pull request Jun 16, 2020
Rollup of 8 pull requests

Successful merges:

 - rust-lang#73237 (Check for overflow in DroplessArena and align returned memory)
 - rust-lang#73339 (Don't run generator transform when there's a TyErr)
 - rust-lang#73372 (Re-order correctly the sections in the sidebar)
 - rust-lang#73373 (Use track caller for bug! macro)
 - rust-lang#73380 (Add more info to `x.py build --help` on default value for `-j JOBS`.)
 - rust-lang#73381 (Fix typo in docs of std::mem)
 - rust-lang#73389 (Use `Ipv4Addr::from<[u8; 4]>` when possible)
 - rust-lang#73400 (Fix forge-platform-support URL)

Failed merges:

r? @ghost
@bors bors merged commit 3c437e5 into rust-lang:master Jun 16, 2020
@tesuji tesuji deleted the from branch June 16, 2020 19:31
@dtolnay dtolnay added the T-libs Relevant to the library team, which will review and decide on the PR/issue. label Jun 19, 2020
@cuviper cuviper added this to the 1.46 milestone May 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-libs Relevant to the library team, which will review and decide on the PR/issue.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants