Skip to content

resolve: Relax fresh binding disambiguation slightly to fix regression #71846

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
May 5, 2020
Merged

resolve: Relax fresh binding disambiguation slightly to fix regression #71846

merged 1 commit into from
May 5, 2020

Conversation

petrochenkov
Copy link
Contributor

Fixes #71765

@rust-highfive
Copy link
Contributor

r? @davidtwco

(rust_highfive has picked a reviewer for you, use r? to override)

@rust-highfive rust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label May 3, 2020
@petrochenkov petrochenkov mentioned this pull request May 3, 2020
Closed
@jonas-schievink jonas-schievink added beta-nominated Nominated for backporting to the compiler in the beta channel. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. labels May 3, 2020
@davidtwco
Copy link
Member

@bors r+

@bors
Copy link
Collaborator

bors commented May 4, 2020

📌 Commit 5b84d5f has been approved by davidtwco

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels May 4, 2020
@Dylan-DPC-zz
Copy link

@bors p=1

@bors
Copy link
Collaborator

bors commented May 4, 2020

⌛ Testing commit 5b84d5f with merge 4e0221256842d412acf606a7d1cba012a61cf3a4...

@Dylan-DPC-zz
Copy link

@bors retry yield

@bors
Copy link
Collaborator

bors commented May 5, 2020

⌛ Testing commit 5b84d5f with merge de27cd7...

@bors
Copy link
Collaborator

bors commented May 5, 2020

☀️ Test successful - checks-azure
Approved by: davidtwco
Pushing de27cd7 to master...

@bors bors added the merged-by-bors This PR was explicitly merged by bors. label May 5, 2020
@bors bors merged commit de27cd7 into rust-lang:master May 5, 2020
@pnkfelix
Copy link
Contributor

pnkfelix commented May 6, 2020

unilaterally accepting for beta-backport.

@pnkfelix pnkfelix added the beta-accepted Accepted for backporting to the compiler in the beta channel. label May 6, 2020
@Mark-Simulacrum Mark-Simulacrum removed the beta-nominated Nominated for backporting to the compiler in the beta channel. label May 9, 2020
@Mark-Simulacrum Mark-Simulacrum mentioned this pull request May 9, 2020
Merged
bors added a commit to rust-lang-ci/rust that referenced this pull request May 11, 2020
@bors
Auto merge of rust-lang#72054 - Mark-Simulacrum:beta-next, r=Mark-Sim…
0f0d700 
…ulacrum

[beta] backports

This backport rollup includes the following:
 * [beta] Update cargo rust-lang#71967
 * Backport 1.43.1 release notes to master rust-lang#71914
 * Update the `cc` crate rust-lang#71882
 * resolve: Relax fresh binding disambiguation slightly to fix regression rust-lang#71846
 * Do not try to find binop method on RHS `TyErr` rust-lang#71810
 * Quick and dirty fix of the unused_braces lint rust-lang#71517
 * Update stdarch submodule rust-lang#71495
 * normalize field projection ty to fix broken MIR issue rust-lang#71488
 * Update openssl-src to 1.1.1g rust-lang#71430
 * fix error code in E0751.md rust-lang#71426
 * Don't fuse Chain in its second iterator rust-lang#71404
 * Remove some `Vec` allocations to improve performance rust-lang#71268
 * [CI] Use the latest Python available on Windows rust-lang#71995

It also switches the bootstrap compiler to 1.43.1.
@petrochenkov petrochenkov deleted the fresh2 branch February 22, 2025 18:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@davidtwco davidtwco davidtwco approved these changes

Assignees

@davidtwco davidtwco

Labels
beta-accepted Accepted for backporting to the compiler in the beta channel. merged-by-bors This PR was explicitly merged by bors. S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[regression] ambiguous local variable
8 participants
@petrochenkov @rust-highfive @davidtwco @bors @Dylan-DPC-zz @pnkfelix @jonas-schievink @Mark-Simulacrum