Rollup of 5 pull requests #71105
Merged
Rollup of 5 pull requests #71105
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
converting ints in librustc_typeck Fixes rust-lang#70851
…demand.rs Add tests for *size
…=kinnison Improve scrollbar display in rustdoc The scrollbar of the left sidebar in rustdoc looks very bad on firefox (on dark theme). This PR improves it: <div style="display:inline-block;"> <div style="width:50%;display:inline-block;float:left;"> <image src="https://user-images.githubusercontent.com/3050060/78148412-202b0380-7435-11ea-8ff3-79f02ea8f9ed.png"> </div> <div style="width:50%;display:inline-block;float:left;"> <image src="https://user-images.githubusercontent.com/3050060/78148437-28833e80-7435-11ea-946b-a6fc9320b705.png"> </div> </div> With light theme:   And on chrome:   Small extra question: should I extend it to all scrollbars? I think it'd be better but just in case... r? @kinnison
Suggest .into() over try_into() when it would work It would be better to suggest x.into() instead, which is shorter, cannot fail, and doesn't require importing a trait. Tests have been added and made up to date. Fixes rust-lang#70851
Remove `FnCtxt::impl_self_ty` Fixes rust-lang#69489 r? @eddyb cc @Centril
…static-morse Miri: let machine hook dynamically decide about alignment checks This is needed for rust-lang/miri#1332.
|
@bors r+ rollup=never p=5 |
|
📌 Commit 73e56de has been approved by |
bors
added
the
S-waiting-on-bors
|
☀️ Test successful - checks-azure |
|
📣 Toolstate changed by #71105! Tested on commit 8e18e26. 💔 miri on windows: test-pass → build-fail (cc @oli-obk @eddyb @RalfJung). |
rust-highfive
added a commit
to rust-lang-nursery/rust-toolstate
that referenced
this pull request
Apr 13, 2020
Tested on commit rust-lang/rust@8e18e26. Direct link to PR: <rust-lang/rust#71105> 💔 miri on windows: test-pass → build-fail (cc @oli-obk @eddyb @RalfJung). 💔 miri on linux: test-pass → build-fail (cc @oli-obk @eddyb @RalfJung). 🎉 rustc-dev-guide on linux: test-fail → test-pass (cc @JohnTitor @amanjeev @spastorino @mark-i-m).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Successful merges:
FnCtxt::impl_self_ty#71087 (RemoveFnCtxt::impl_self_ty)Failed merges:
r? @ghost