make mem::discriminant const
#69825
Merged
make mem::discriminant const
#69825
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
r? @eddyb (rust_highfive has picked a reviewer for you, use r? to override) |
rust-highfive
added
the
S-waiting-on-review
RalfJung
reviewed
Mar 8, 2020
|
r? @RalfJung |
|
Sure, but also Cc @rust-lang/wg-const-eval FYI |
RalfJung
reviewed
Mar 8, 2020
This comment has been minimized.
This comment has been minimized.
RalfJung
reviewed
Mar 8, 2020
25 tasks
This comment has been minimized.
This comment has been minimized.
oli-obk
reviewed
Mar 9, 2020
oli-obk
approved these changes
Mar 9, 2020
RalfJung
reviewed
Mar 10, 2020
|
@bors r+ |
|
📌 Commit 7b3e3ff has been approved by |
|
🌲 The tree is currently closed for pull requests below priority 1000, this pull request will be tested once the tree is reopened |
bors
removed
the
S-waiting-on-review
bors
added
the
S-waiting-on-bors
Centril
added a commit
to Centril/rust
that referenced
this pull request
Mar 11, 2020
make `mem::discriminant` const implements rust-lang#69821, which could be used as a tracking issue for `const_discriminant`. Should this be added to the meta tracking issue rust-lang#57563? @Lokathor
bors
added a commit
that referenced
this pull request
Mar 11, 2020
Rollup of 10 pull requests Successful merges: - #66059 (mem::zeroed/uninit: panic on types that do not permit zero-initialization) - #69373 (Stabilize const for integer {to,from}_{be,le,ne}_bytes methods) - #69591 (Use TypeRelating for instantiating query responses) - #69625 (Implement nth, last, and count for iter::Copied) - #69645 (const forget tests) - #69766 (Make Point `Copy` in arithmetic documentation) - #69825 (make `mem::discriminant` const) - #69859 (fix #62456) - #69891 (Exhaustiveness checking, `Matrix::push`: recursively expand or-patterns) - #69896 (parse: Tweak the function parameter edition check) Failed merges: r? @ghost
3 tasks
bors
added a commit
to rust-lang/miri
that referenced
this pull request
Mar 12, 2020
rm custom `intrinsics::discriminant_value` @RalfJung requires rust-lang/rust#69825
bors
added a commit
to rust-lang/miri
that referenced
this pull request
Mar 12, 2020
rm custom `intrinsics::discriminant_value` @RalfJung requires rust-lang/rust#69825
bors
added a commit
to rust-lang/miri
that referenced
this pull request
Mar 12, 2020
rm custom `intrinsics::discriminant_value` @RalfJung requires rust-lang/rust#69825
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
implements #69821, which could be used as a tracking issue for
const_discriminant.Should this be added to the meta tracking issue #57563?
@Lokathor