Skip to content

Conversation

RalfJung
Copy link
Member

Fixes rust-lang/miri#1071

r? @oli-obk

I am not sure if this is the best approach, but it certainly is the easiest.

@rust-highfive rust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Nov 28, 2019
@RalfJung RalfJung changed the title do not consider memory allocated by caller_location leaked Miri: do not consider memory allocated by caller_location leaked Nov 28, 2019
@oli-obk
Copy link
Contributor

oli-obk commented Nov 28, 2019

@bors r+

@bors
Copy link
Collaborator

bors commented Nov 28, 2019

📌 Commit 3048d7e has been approved by oli-obk

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Nov 28, 2019
RalfJung added a commit to RalfJung/rust that referenced this pull request Nov 29, 2019
…i-obk

Miri: do not consider memory allocated by caller_location leaked

Fixes rust-lang/miri#1071

r? @oli-obk

I am not sure if this is the best approach, but it certainly is the easiest.
RalfJung added a commit to RalfJung/rust that referenced this pull request Nov 29, 2019
…i-obk

Miri: do not consider memory allocated by caller_location leaked

Fixes rust-lang/miri#1071

r? @oli-obk

I am not sure if this is the best approach, but it certainly is the easiest.
bors added a commit that referenced this pull request Nov 29, 2019
Rollup of 11 pull requests

Successful merges:

 - #66379 (Rephrase docs in for ptr)
 - #66589 (Draw vertical lines correctly in compiler error messages)
 - #66613 (Allow customising ty::TraitRef's printing behavior)
 - #66766 (Panic machinery comments and tweaks)
 - #66791 (Handle GlobalCtxt directly from librustc_interface query system)
 - #66793 (Record temporary static references in generator witnesses)
 - #66808 (Cleanup error code)
 - #66826 (Clarifies how to tag users for assigning PRs)
 - #66837 (Clarify `{f32,f64}::EPSILON` docs)
 - #66844 (Miri: do not consider memory allocated by caller_location leaked)
 - #66872 (Minor documentation fix)

Failed merges:

r? @ghost
@bors bors merged commit 3048d7e into rust-lang:master Nov 30, 2019
@RalfJung RalfJung deleted the caller-location-leak branch November 30, 2019 07:50
bors added a commit to rust-lang/miri that referenced this pull request Dec 1, 2019
test more panics

Add some tests for #1071.

Blocked on rust-lang/rust#66844.
bors added a commit to rust-lang/miri that referenced this pull request Dec 1, 2019
test more panics

Add some tests for #1071.

Blocked on rust-lang/rust#66844.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Throwing a panic via core::panic reports memory leak
4 participants