Set RUST_BACKTRACE=0 in tests that include a backtrace in stderr #65018
Conversation
This removes the implicit dependency on the environment variables set when running `./x.py test`
|
(rust_highfive has picked a reviewer for you, use r? to override) |
rust-highfive
added
the
S-waiting-on-review
|
We might want to consider setting Alternatively, we could sanitize the environment variables used when running test - if something isn't set by a |
|
I believe RUST_BACKTRACE=1 can have nonzero (and fairly significant) overhead on runtimes, or at least, we've had reports of such in the past, so I would be hesitant to set it on CI by default. I feel like fixing this when it comes up is not too hard (and it'd be good to document this in compiletest). I'd probably be fine with tests implicitly sanitizing RUST_BACKTRACE though so long as we have the two overrides: the test can manually say "always run me with, or without, a backtrace" and an override that globally sets RUST_BACKTRACE to something bypassing sanitization, though not the test-specific override probably. |
|
@bors r+ (what @Mark-Simulacrum said) |
|
📌 Commit a336536 has been approved by |
bors
added
S-waiting-on-bors
…ikomatsakis Set RUST_BACKTRACE=0 in tests that include a backtrace in stderr This removes the implicit dependency on the environment variables set when running `./x.py test`
…ikomatsakis Set RUST_BACKTRACE=0 in tests that include a backtrace in stderr This removes the implicit dependency on the environment variables set when running `./x.py test`
Rollup of 11 pull requests Successful merges: - #61879 (Stabilize todo macro) - #64675 (Deprecate `#![plugin]` & `#[plugin_registrar]`) - #64690 (proc_macro API: Expose `macro_rules` hygiene) - #64706 (add regression test for #60218) - #64741 (Prevent rustdoc feature doctests) - #64842 (Disallow Self in type param defaults of ADTs) - #65004 (Replace mentions of IRC with Discord) - #65018 (Set RUST_BACKTRACE=0 in tests that include a backtrace in stderr) - #65055 (Add long error explanation for E0556) - #65056 (Make visit projection iterative) - #65057 (typo: fix typo in E0392) Failed merges: r? @ghost
This removes the implicit dependency on the environment variables set
when running
./x.py test