Skip to content

bootstrap: allow specifying mirror for bootstrap compiler download. #63953

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Aug 29, 2019
Merged

bootstrap: allow specifying mirror for bootstrap compiler download. #63953

merged 1 commit into from
Aug 29, 2019

Conversation

crlf0710
Copy link
Member

No description provided.

@rust-highfive
Copy link
Contributor

r? @nikomatsakis

(rust_highfive has picked a reviewer for you, use r? to override)

@rust-highfive rust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Aug 27, 2019
@Mark-Simulacrum
Copy link
Member

I'd personally prefer that this is done via config.toml rustc/cargo flags -- is there a common use case for this?

@crlf0710
Copy link
Member Author

r? @Mark-Simulacrum

@crlf0710
Copy link
Member Author

@Mark-Simulacrum yes, rustup already supports the RUSTUP_DIST_SERVER variable, and for people in mainland china, we already have this environment variable set for daily usage. It's a little more convenient.

@Mark-Simulacrum
Copy link
Member

In that case @bors r+ though I'll also cc @alexcrichton in case he has any thoughts here

@bors
Copy link
Collaborator

bors commented Aug 27, 2019

📌 Commit c9bf5c0 has been approved by Mark-Simulacrum

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Aug 27, 2019
@bors
Copy link
Collaborator

bors commented Aug 29, 2019

⌛ Testing commit c9bf5c0 with merge a9f473d1c75747831893dcf90220551b90f9aeae...

Centril added a commit to Centril/rust that referenced this pull request Aug 29, 2019
@Centril
Rollup merge of rust-lang#63953 - crlf0710:bootstrap_mirroring, r=Mar…
78e728e 
…k-Simulacrum

bootstrap: allow specifying mirror for bootstrap compiler download.
@Centril Centril mentioned this pull request Aug 29, 2019
Merged
@Centril
Copy link
Contributor

Centril commented Aug 29, 2019

@bors retry rolled up.

bors added a commit that referenced this pull request Aug 29, 2019
@bors
Auto merge of #64000 - Centril:rollup-70s9ar3, r=Centril
fbdf1d2 
Rollup of 4 pull requests

Successful merges:

 - #62734 (Hide trait default methods)
 - #63953 (bootstrap: allow specifying mirror for bootstrap compiler download.)
 - #63956 (rustc: Handle modules in "fat" LTO more robustly)
 - #63979 (std: Remove the `wasm_syscall` feature)

Failed merges:

r? @ghost
@bors
Copy link
Collaborator

bors commented Aug 29, 2019

⌛ Testing commit c9bf5c0 with merge fbdf1d2...

@bors bors merged commit c9bf5c0 into rust-lang:master Aug 29, 2019
@crlf0710 crlf0710 deleted the bootstrap_mirroring branch August 29, 2019 19:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@Mark-Simulacrum Mark-Simulacrum

Labels
S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@crlf0710 @rust-highfive @Mark-Simulacrum @bors @Centril @nikomatsakis