Skip to content

Conversation

frewsxcv
Copy link
Contributor

tbu- and others added 12 commits June 27, 2017 12:09
Try to make clear that this isn't an API guarantee for now, as we likely
want to refine these errors in the future, e.g. `ENOSPC` "No space left
on device".

CC rust-lang#40322
Add pager support for `rustc --explain EXXXX`

Hello!

This is my take on rust-lang#32665.

Thanks!

**EDIT:** _I've limited access to a Windows machine so this is taking longer than I've anticipated_. 🐢

cc @alexcrichton @nikomatsakis @Mark-Simulacrum @retep998 @ollie27 @afiune
…r=GuillaumeGomez

Document possible `io::ErrorKind`s of `fs::open`

Try to make clear that this isn't an API guarantee for now, as we likely
want to refine these errors in the future, e.g. `ENOSPC` "No space left
on device".

CC rust-lang#40322
@rust-highfive
Copy link
Contributor

Thanks for the pull request, and welcome! The Rust team is excited to review your changes, and you should hear from @arielb1 (or someone else) soon.

If any changes to this PR are deemed necessary, please add them as extra commits. This ensures that the reviewer can see what has changed since they last reviewed the code. Due to the way GitHub handles out-of-date commits, this should also make it reasonably obvious what issues have or haven't been addressed. Large or tricky changes may require several passes of review and changes.

Please see the contribution instructions for more information.

@frewsxcv
Copy link
Contributor Author

@bors r+ rollup

@bors
Copy link
Collaborator

bors commented Jun 30, 2017

📌 Commit dea34bd has been approved by frewsxcv

@frewsxcv
Copy link
Contributor Author

@bors p=10

@frewsxcv
Copy link
Contributor Author

@bors rollup-

@bors
Copy link
Collaborator

bors commented Jun 30, 2017

⌛ Testing commit dea34bd with merge 3da4baaa2c1a8bd6bf3977fe24e7633b9c1deda9...

@bors
Copy link
Collaborator

bors commented Jun 30, 2017

💔 Test failed - status-appveyor

@kennytm
Copy link
Member

kennytm commented Jun 30, 2017

Legit? Trailing line in UI test ui/explain.rs. #42732.

@Centril Centril added the rollup A PR which is a rollup label Oct 24, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
rollup A PR which is a rollup
Projects
None yet
Development

Successfully merging this pull request may close these issues.