Skip to content

Improve E0119 error explanation #27350

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jul 29, 2015
Merged

Improve E0119 error explanation #27350

merged 1 commit into from
Jul 29, 2015

Conversation

GuillaumeGomez
Copy link
Member

Manishearth
Manishearth reviewed Jul 28, 2015
View reviewed changes
src/librustc_typeck/diagnostics.rs
@@ -1285,7 +1285,10 @@ impl MyTrait for Foo { // error: conflicting implementations for trait
}
```

When you write:
When looking for the implementation for the trait, the compiler finds
both the `impl MyTrait for T` where T is all types and the `impl
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

impl<T>

@Manishearth
Copy link
Member

@bors r+ rollup

@bors
Copy link
Collaborator

bors commented Jul 28, 2015

📌 Commit cf55db2 has been approved by Manishearth

@GuillaumeGomez GuillaumeGomez mentioned this pull request Jul 28, 2015
Closed
steveklabnik added a commit to steveklabnik/rust that referenced this pull request Jul 29, 2015
@steveklabnik
Rollup merge of rust-lang#27350 - GuillaumeGomez:patch-1, r=Manishearth
d3dc1e5 
cc rust-lang#26970.

r? @Manishearth
@steveklabnik steveklabnik mentioned this pull request Jul 29, 2015
Merged
bors added a commit that referenced this pull request Jul 29, 2015
@bors
Auto merge of #27380 - steveklabnik:rollup, r=steveklabnik
ddbce11 
- Successful merges: #27102, #27286, #27313, #27325, #27326, #27327, #27341, #27342, #27343, #27345, #27350, #27355, #27374, #27375, #27379
- Failed merges:
@bors bors merged commit cf55db2 into rust-lang:master Jul 29, 2015
@GuillaumeGomez GuillaumeGomez deleted the patch-1 branch August 12, 2015 10:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@Manishearth Manishearth

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@GuillaumeGomez @Manishearth @bors