Skip to content

Rewrite the dynamic dispatch section to focus on usage rather than implementation. #23234

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Mar 12, 2015
Merged

Rewrite the dynamic dispatch section to focus on usage rather than implementation. #23234

merged 1 commit into from
Mar 12, 2015

Conversation

Ms2ger
Copy link
Contributor

@Ms2ger Ms2ger commented Mar 9, 2015

No description provided.

@rust-highfive
Copy link
Contributor

r? @nikomatsakis

(rust_highfive has picked a reviewer for you, use r? to override)

@Ms2ger
Copy link
Contributor Author

Ms2ger commented Mar 9, 2015

r? @steveklabnik

<njn> Ms2ger: that's definitely an improvement
<njn> Ms2ger: I suggest changing the method name to something other than `method`, because that becomes unclear in the representation section
<njn> Ms2ger: also, is the representation section important to be able to use trait objects? If not, a "you don't really need to know these details" warning would be helpful
<huon> njn: it is helpful to understand certain errors (particularly those around object safety)
<huon> but that's all, AFAIK

If you have wording that would be good for that, please let me know.

steveklabnik
steveklabnik reviewed Mar 11, 2015
View reviewed changes
src/doc/trpl/static-and-dynamic-dispatch.md
Trait objects are both simple and complicated: their core representation and
layout is quite straight-forward, but there are some curly error messages and
surprising behaviors to discover.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why remove this?

@steveklabnik
Copy link
Contributor

I like this overall, my only beef is using that syntax before explaining it. What do you think?

@steveklabnik
Copy link
Contributor

r=me after a squash

@Ms2ger Ms2ger force-pushed the doc-dynamic-dispatch branch from 34d231d to 3ac89d3 Compare March 11, 2015 20:37
@steveklabnik
Copy link
Contributor

@bors: r+ 3ac89d3 rollup

Manishearth added a commit to Manishearth/rust that referenced this pull request Mar 12, 2015
@Manishearth
Rollup merge of rust-lang#23234 - Ms2ger:doc-dynamic-dispatch, r=stev…
497f6b7 
…eklabnik
@bors bors merged commit 3ac89d3 into rust-lang:master Mar 12, 2015
@Ms2ger Ms2ger deleted the doc-dynamic-dispatch branch March 12, 2015 10:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@steveklabnik steveklabnik

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@Ms2ger @rust-highfive @steveklabnik @nikomatsakis @bors