[rustdoc] Fix wrong i tooltip icon
#144913
Merged
+35
−2
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
rustbot
added
S-waiting-on-review
|
Some changes occurred in HTML/CSS/JS. |
This comment has been minimized.
This comment has been minimized.
GuillaumeGomez
force-pushed
the
fix-wrong-i-icon
branch
from
1eb2d44 to
2260749
Compare
lolbinarycat
reviewed
Aug 4, 2025
| @@ -0,0 +1,15 @@ | |||
| // This test checks that the right font is applied to the `i` tooltip element. | |||
There was a problem hiding this comment.
I think this should probably mention this is technically a regression test for #144778 (and also the PR description should mention this fixes that issue)
There was a problem hiding this comment.
Just checked, it doesn't address #144778.
There was a problem hiding this comment.
Resolving conversation then. Thanks for confirming it @fmease!
lolbinarycat
reviewed
Aug 4, 2025
| @@ -767,3 +767,17 @@ pub mod impls_indent { | |||
| pub fn bar() {} | |||
| } | |||
| } | |||
|
|
|||
| pub mod tooltips { | |||
| pub struct X; | |||
There was a problem hiding this comment.
should we also try with <div class="warning"></div> like in the original issue, just to make sure?
There was a problem hiding this comment.
Like said above, can't reproduce the bug for this case. ;)
fmease
approved these changes
Aug 5, 2025
|
@bors r=fmease rollup |
bors
added
S-waiting-on-bors
Zalathar
added a commit
to Zalathar/rust
that referenced
this pull request
Aug 6, 2025
…=fmease [rustdoc] Fix wrong `i` tooltip icon Current wrong display: <img width="334" height="37" alt="Screenshot From 2025-08-04 17-42-38" src="https://github.com/user-attachments/assets/57046475-6162-487f-998f-ebb2434c111d" /> With the fix: <img width="334" height="37" alt="image" src="https://github.com/user-attachments/assets/e761a103-dc39-4e30-8c8e-cfc7fab52fde" /> r? `@fmease`
bors
added a commit
that referenced
this pull request
Aug 6, 2025
Rollup of 21 pull requests Successful merges: - #137831 (Tweak auto trait errors) - #138689 (add nvptx_target_feature) - #140267 (implement continue_ok and break_ok for ControlFlow) - #143679 (Preserve the .debug_gdb_scripts section) - #143857 (Port #[macro_export] to the new attribute parsing infrastructure) - #143929 (Mark all deprecation lints in name resolution as deny-by-default and report-in-deps) - #144133 (Stabilize const TypeId::of) - #144369 (Upgrade semicolon_in_expressions_from_macros from warn to deny) - #144473 (Address libunwind.a inconsistency issues in the bootstrap program) - #144498 (Add --print target-spec-json-schema) - #144552 (Rehome 33 `tests/ui/issues/` tests to other subdirectories under `tests/ui/`) - #144659 (bootstrap: refactor mingw dist and fix gnullvm) - #144676 (Add documentation for unstable_feature_bound) - #144794 (Port `#[coroutine]` to the new attribute system) - #144835 (Anonymize binders in tail call sig) - #144836 (Change visibility of Args new function) - #144861 (Stabilize `panic_payload_as_str` feature) - #144910 (Add regression tests for seemingly fixed issues) - #144913 ([rustdoc] Fix wrong `i` tooltip icon) - #144917 (Enforce tail call type is related to body return type in borrowck) - #144924 (compiletest: add hint for when a ui test produces no errors) r? `@ghost` `@rustbot` modify labels: rollup
bors
added a commit
that referenced
this pull request
Aug 6, 2025
Rollup of 12 pull requests Successful merges: - #144552 (Rehome 33 `tests/ui/issues/` tests to other subdirectories under `tests/ui/`) - #144676 (Add documentation for unstable_feature_bound) - #144836 (Change visibility of Args new function) - #144910 (Add regression tests for seemingly fixed issues) - #144913 ([rustdoc] Fix wrong `i` tooltip icon) - #144924 (compiletest: add hint for when a ui test produces no errors) - #144926 (Correct the use of `must_use` on btree::IterMut) - #144928 (Drop `rust-version` from `rustc_thread_pool`) - #144945 (Autolabel PRs that change explicit tail call tests as `F-explicit_tail_calls`) - #144954 (run-make: Allow blessing snapshot files that don't exist yet) - #144971 (num: Rename `isolate_most_least_significant_one` functions) - #144978 (Fix some doc links for intrinsics) r? `@ghost` `@rustbot` modify labels: rollup
rust-timer
added a commit
that referenced
this pull request
Aug 6, 2025
Rollup merge of #144913 - GuillaumeGomez:fix-wrong-i-icon, r=fmease [rustdoc] Fix wrong `i` tooltip icon Current wrong display: <img width="334" height="37" alt="Screenshot From 2025-08-04 17-42-38" src="https://github.com/user-attachments/assets/57046475-6162-487f-998f-ebb2434c111d" /> With the fix: <img width="334" height="37" alt="image" src="https://github.com/user-attachments/assets/e761a103-dc39-4e30-8c8e-cfc7fab52fde" /> r? ``@fmease``
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Current wrong display:
With the fix:
r? @fmease