Skip to content

CI: fix name of jobs #135303

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jan 10, 2025
Merged

CI: fix name of jobs #135303

merged 1 commit into from
Jan 10, 2025
+4 −4

Conversation

Kobzol
Copy link
Member

@Kobzol Kobzol commented Jan 9, 2025

There is a difference between the image (the Dockerfile), the name of the job (which determines also its properties) and the full_name, which includes the auto/try/pr prefix.

Missed this in #134898.

@Kobzol
CI: fix name of jobs
c8b29d6 
There is a difference between the `image` (the Dockerfile), the `name` of the job (which determines also its properties) and the `full_name`, which includes the `auto/try/pr` prefix.
@rustbot
Copy link
Collaborator

rustbot commented Jan 9, 2025

r? @Mark-Simulacrum

rustbot has assigned @Mark-Simulacrum.
They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.

Use r? to explicitly pick a reviewer

@rustbot rustbot added A-testsuite Area: The testsuite used to check the correctness of rustc S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-infra Relevant to the infrastructure team, which will review and decide on the PR/issue. labels Jan 9, 2025
@Kobzol
Copy link
Member Author

Kobzol commented Jan 9, 2025 •
edited
Loading

@bors p=1000 (to unblock CI)

@rust-log-analyzer
Copy link
Collaborator

The job x86_64-gnu-tools failed! Check out the build log: (web) (plain)

Click to see the possible cause of the failure (guessed by this bot) 
curl: (22) The requested URL returned error: 404
curl: (22) The requested URL returned error: 404
ERROR: failed to download llvm from ci

    HELP: There could be two reasons behind this:
        1) The host triple is not supported for `download-ci-llvm`.
        2) Old builds get deleted after a certain time.
    HELP: In either case, disable `download-ci-llvm` in your config.toml:
    [llvm]
    download-ci-llvm = false
    
Build completed unsuccessfully in 0:00:22

@Kobzol Kobzol mentioned this pull request Jan 9, 2025
Merged
@Kobzol
Copy link
Member Author

Kobzol commented Jan 9, 2025

An S3 archive has to be copied before CI can progress.

@tgross35 tgross35 closed this Jan 9, 2025
@tgross35 tgross35 reopened this Jan 9, 2025
@tgross35
Copy link
Contributor

This change is reasonably straightforward and makes sense to me, so I think it is okay to merge.

@bors r+ rollup=never

@bors
Copy link
Collaborator

bors commented Jan 10, 2025

📌 Commit c8b29d6 has been approved by tgross35

It is now in the queue for this repository.

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Jan 10, 2025
@bors
Copy link
Collaborator

bors commented Jan 10, 2025

⌛ Testing commit c8b29d6 with merge 62bf38f...

@bors
Copy link
Collaborator

bors commented Jan 10, 2025

☀️ Test successful - checks-actions
Approved by: tgross35
Pushing 62bf38f to master...

@bors bors added the merged-by-bors This PR was explicitly merged by bors. label Jan 10, 2025
@bors bors merged commit 62bf38f into rust-lang:master Jan 10, 2025
9 of 13 checks passed
@rustbot rustbot added this to the 1.86.0 milestone Jan 10, 2025
@tgross35
Copy link
Contributor

@bors treeclosed-

@Kobzol Kobzol deleted the ci-fix-name branch January 10, 2025 06:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@Mark-Simulacrum Mark-Simulacrum

Labels
A-testsuite Area: The testsuite used to check the correctness of rustc merged-by-bors This PR was explicitly merged by bors. S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-infra Relevant to the infrastructure team, which will review and decide on the PR/issue.
Projects
None yet
Milestone
1.86.0
Development

Successfully merging this pull request may close these issues.
6 participants
@Kobzol @rustbot @rust-log-analyzer @tgross35 @bors @Mark-Simulacrum