Skip to content

Conversation

lcnr
Copy link
Contributor

@lcnr lcnr commented May 6, 2024

otherwise we ICE due to ambiguity when normalizing while computing implied bounds.

r? @compiler-errors

@rustbot rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. WG-trait-system-refactor The Rustc Trait System Refactor Initiative (-Znext-solver) labels May 6, 2024
@rustbot
Copy link
Collaborator

rustbot commented May 6, 2024

Some changes occurred to the core trait solver

cc @rust-lang/initiative-trait-system-refactor

@lcnr
Copy link
Contributor Author

lcnr commented May 6, 2024

@bors r=compiler-errors rollup

@bors
Copy link
Collaborator

bors commented May 6, 2024

📌 Commit 5714c1f has been approved by compiler-errors

It is now in the queue for this repository.

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels May 6, 2024
matthiaskrgr added a commit to matthiaskrgr/rust that referenced this pull request May 6, 2024
…er-errors

borrowck: prepopulate opaque storage more eagerly

otherwise we ICE due to ambiguity when normalizing while computing implied bounds.

r? `@compiler-errors`
bors added a commit to rust-lang-ci/rust that referenced this pull request May 6, 2024
…iaskrgr

Rollup of 4 pull requests

Successful merges:

 - rust-lang#124209 (Make check-cfg docs more user-friendly)
 - rust-lang#124759 (Record impl args in the proof tree in new solver)
 - rust-lang#124809 (borrowck: prepopulate opaque storage more eagerly)
 - rust-lang#124815 (Update books)

r? `@ghost`
`@rustbot` modify labels: rollup
bors added a commit to rust-lang-ci/rust that referenced this pull request May 6, 2024
…iaskrgr

Rollup of 3 pull requests

Successful merges:

 - rust-lang#124759 (Record impl args in the proof tree in new solver)
 - rust-lang#124809 (borrowck: prepopulate opaque storage more eagerly)
 - rust-lang#124815 (Update books)

r? `@ghost`
`@rustbot` modify labels: rollup
@bors bors merged commit 284b553 into rust-lang:master May 6, 2024
@rustbot rustbot added this to the 1.80.0 milestone May 6, 2024
rust-timer added a commit to rust-lang-ci/rust that referenced this pull request May 6, 2024
Rollup merge of rust-lang#124809 - lcnr:prepopulate-opaques, r=compiler-errors

borrowck: prepopulate opaque storage more eagerly

otherwise we ICE due to ambiguity when normalizing while computing implied bounds.

r? ``@compiler-errors``
@lcnr lcnr deleted the prepopulate-opaques branch May 7, 2024 02:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. WG-trait-system-refactor The Rustc Trait System Refactor Initiative (-Znext-solver)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants