miscellaneous type system improvements #121359
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rustbot
added
S-waiting-on-review
|
Type relation code was changed Some changes occurred to the core trait solver cc @rust-lang/initiative-trait-system-refactor |
lcnr
commented
Feb 20, 2024
| )?; | ||
| } | ||
|
|
||
| Ok(()) |
lcnr
changed the title
lcnr
commented
Feb 20, 2024
| }; | ||
| self.in_alias = is_nested_alias; | ||
| result | ||
| } |
There was a problem hiding this comment.
extracts the alias code into a separate method. generally useful as it's quite involved and also part of #119106
lcnr
commented
Feb 20, 2024
| // keep the projection unnormalized. This is the case for projections | ||
| // with a `T: Trait` where-clause and opaque types outside of the defining | ||
| // scope. | ||
| let result = if infcx.predicate_may_hold(&obligation) { |
There was a problem hiding this comment.
by using AliasRelate rigid projections don't result in errors anymore
lcnr
commented
Feb 20, 2024
| mod inherent; | ||
| mod opaques; | ||
| mod opaque_types; |
There was a problem hiding this comment.
match the name for all other opaque types files in rustc
lcnr
force-pushed
the
typesystem-cleanup
branch
from
0dc5930 to
5fb67e2
Compare
compiler-errors
approved these changes
Feb 20, 2024
|
@bors r+ |
bors
added
S-waiting-on-bors
bors
added a commit
to rust-lang-ci/rust
that referenced
this pull request
Feb 21, 2024
Rollup of 8 pull requests Successful merges: - rust-lang#121044 (Support async trait bounds in macros) - rust-lang#121175 (match lowering: test one or pattern at a time) - rust-lang#121340 (bootstrap: apply most of clippy's suggestions) - rust-lang#121347 (compiletest: support auxiliaries with auxiliaries) - rust-lang#121359 (miscellaneous type system improvements) - rust-lang#121366 (Remove `diagnostic_builder.rs`) - rust-lang#121379 (Remove an `unchecked_error_guaranteed` call.) - rust-lang#121396 (make it possible for outside crates to inspect a mir::ConstValue with the interpreter) r? `@ghost` `@rustbot` modify labels: rollup
rust-timer
added a commit
to rust-lang-ci/rust
that referenced
this pull request
Feb 21, 2024
Rollup merge of rust-lang#121359 - lcnr:typesystem-cleanup, r=compiler-errors miscellaneous type system improvements see review comments for rationale r? `@compiler-errors`
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
see review comments for rationale
r? @compiler-errors