Skip to content

Add myself back to review rotation #114953

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Aug 19, 2023
Merged

Add myself back to review rotation #114953

merged 1 commit into from
Aug 19, 2023

Conversation

WaffleLapkin
Copy link
Member

r? @ghost

@rustbot rustbot added A-meta Area: Issues & PRs about the rust-lang/rust repository itself S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Aug 18, 2023
@WaffleLapkin
Copy link
Member Author

@bors r+ rollup

@bors
Copy link
Collaborator

bors commented Aug 18, 2023

📌 Commit 54bd826 has been approved by WaffleLapkin

It is now in the queue for this repository.

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Aug 18, 2023
matthiaskrgr added a commit to matthiaskrgr/rust that referenced this pull request Aug 18, 2023
@matthiaskrgr
Rollup merge of rust-lang#114953 - WaffleLapkin:waffle-back-to-rotati…
6255a2b 
…on-hehehee, r=WaffleLapkin

Add myself back to review rotation

r? `@ghost`
@matthiaskrgr matthiaskrgr mentioned this pull request Aug 18, 2023
Closed
@matthiaskrgr matthiaskrgr mentioned this pull request Aug 19, 2023
Merged
bors added a commit to rust-lang-ci/rust that referenced this pull request Aug 19, 2023
@bors
Auto merge of rust-lang#114980 - matthiaskrgr:rollup-3y7651q, r=matth…
3e50a64 
…iaskrgr

Rollup of 5 pull requests

Successful merges:

 - rust-lang#114953 (Add myself back to review rotation)
 - rust-lang#114958 (`ignore-cross-compile` on `optimization-remarks-dir-pgo` test)
 - rust-lang#114971 (Add doc aliases for trigonometry and other f32,f64 methods.)
 - rust-lang#114972 (Add a test to check that inline const is in required_consts)
 - rust-lang#114977 (Add `modulo` and `mod` as doc aliases for `rem_euclid`.)

r? `@ghost`
`@rustbot` modify labels: rollup
@bors bors merged commit 0e609c4 into rust-lang:master Aug 19, 2023
@rustbot rustbot added this to the 1.73.0 milestone Aug 19, 2023
@WaffleLapkin WaffleLapkin deleted the waffle-back-to-rotation-hehehee branch November 19, 2023 00:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
A-meta Area: Issues & PRs about the rust-lang/rust repository itself S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion.
Projects
None yet
Milestone
1.73.0
Development

Successfully merging this pull request may close these issues.
3 participants
@WaffleLapkin @bors @rustbot