DescriptionCtx cleanups
#110210
Merged
DescriptionCtx cleanups
#110210
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It has a single callsite.
It has a single call site, and the code is clearer with all region kinds handled in one function, instead of splitting the handling across two functions. The commit also changes `DescriptionCtx::new` to use a more declarative style, instead of creating a default `DescriptionCtx` and modifying it, which I find easier to read.
For similar reasons to the previous commit.
rustbot
added
S-waiting-on-review
|
@bors rollup |
|
@bors r+ |
bors
added
S-waiting-on-bors
bors
added a commit
to rust-lang-ci/rust
that referenced
this pull request
Apr 12, 2023
…iaskrgr Rollup of 8 pull requests Successful merges: - rust-lang#109959 (Fix transmute intrinsic mir validation ICE) - rust-lang#110176 (Renumbering cleanups) - rust-lang#110182 (Use `itertools::Either` instead of own impl) - rust-lang#110188 (Remove orphaned remove_dir_all implementation from rust-installer) - rust-lang#110190 (Custom MIR: Support `BinOp::Offset`) - rust-lang#110209 (Add regression test for rust-lang#59003) - rust-lang#110210 (`DescriptionCtx` cleanups) - rust-lang#110217 (doc: loongarch: Fix typos) Failed merges: r? `@ghost` `@rustbot` modify labels: rollup
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Best reviewed one commit at a time.
r? @davidtwco