Skip to content

don't destuct references just to reborrow #105875

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Dec 18, 2022
Merged

don't destuct references just to reborrow #105875

merged 1 commit into from
Dec 18, 2022

Conversation

matthiaskrgr
Copy link
Member

No description provided.

@rustbot
Copy link
Collaborator

rustbot commented Dec 18, 2022

r? @davidtwco

(rustbot has picked a reviewer for you, use r? to override)

@rustbot rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. labels Dec 18, 2022
@rustbot
Copy link
Collaborator

rustbot commented Dec 18, 2022

Some changes occurred to the CTFE / Miri engine

cc @rust-lang/miri

@matthiaskrgr matthiaskrgr reopened this Dec 18, 2022
@matthiaskrgr matthiaskrgr changed the title don't restuct references just to reborrow don't destuct references just to reborrow Dec 18, 2022
@oli-obk
Copy link
Contributor

oli-obk commented Dec 18, 2022

r? @oli-obk

@bors r+ rollup

@bors
Copy link
Collaborator

bors commented Dec 18, 2022

📌 Commit a108d55 has been approved by oli-obk

It is now in the queue for this repository.

@rustbot rustbot assigned oli-obk and unassigned davidtwco Dec 18, 2022
@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Dec 18, 2022
@matthiaskrgr matthiaskrgr mentioned this pull request Dec 18, 2022
Merged
bors added a commit to rust-lang-ci/rust that referenced this pull request Dec 18, 2022
@bors
Auto merge of rust-lang#105876 - matthiaskrgr:rollup-a9dgzjt, r=matth…
d0dc9ef 
…iaskrgr

Rollup of 7 pull requests

Successful merges:

 - rust-lang#96584 (Fix `x setup -h -v` should work)
 - rust-lang#105420 (Remove dead code after destination propagation)
 - rust-lang#105844 (Make the x tool use the x and x.ps1 scripts)
 - rust-lang#105854 (remove redundant clone)
 - rust-lang#105858 (Another `as_chunks` example)
 - rust-lang#105870 (avoid .into() conversion to identical types)
 - rust-lang#105875 (don't destuct references just to reborrow)

Failed merges:

r? `@ghost`
`@rustbot` modify labels: rollup
@rust-log-analyzer
Copy link
Collaborator

The job mingw-check failed! Check out the build log: (web) (plain)

Click to see the possible cause of the failure (guessed by this bot) 

curl: (35) OpenSSL SSL_connect: SSL_ERROR_SYSCALL in connection to ci-artifacts.rust-lang.org:443 
error: failed to download llvm from ci

    help: old builds get deleted after a certain time
    help: if trying to compile an old commit of rustc, disable `download-ci-llvm` in config.toml:

    [llvm]
    download-ci-llvm = false
Build completed unsuccessfully in 0:02:22

@bors bors merged commit 2237977 into rust-lang:master Dec 18, 2022
@rustbot rustbot added this to the 1.68.0 milestone Dec 18, 2022
@matthiaskrgr matthiaskrgr deleted the needless_borrowed_reference branch January 25, 2025 09:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@oli-obk oli-obk

Labels
S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue.
Projects
None yet
Milestone
1.68.0
Development

Successfully merging this pull request may close these issues.
6 participants
@matthiaskrgr @rustbot @oli-obk @bors @rust-log-analyzer @davidtwco