Skip to content

Conversation

Noratrieb
Copy link
Member

Removes a few lifetimes and renames some.

r? @GuillaumeGomez

Removes a few lifetimes and renames some.
@rustbot rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-rustdoc Relevant to the rustdoc team, which will review and decide on the PR/issue. labels Dec 10, 2022
/// This field is used to calculate precise local URLs.
pub(crate) current_href: &'c str,
pub(crate) current_href: String,
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice finding!

@GuillaumeGomez
Copy link
Member

Thanks! I don't think there is any need for a perf check so let's just approve it.

@bors r+ rollup

@bors
Copy link
Collaborator

bors commented Dec 10, 2022

📌 Commit 4850450 has been approved by GuillaumeGomez

It is now in the queue for this repository.

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Dec 10, 2022
matthiaskrgr added a commit to matthiaskrgr/rust that referenced this pull request Dec 10, 2022
…ifetimes, r=GuillaumeGomez

Clean up lifetimes in rustdoc syntax highlighting

Removes a few lifetimes and renames some.

r? `@GuillaumeGomez`
bors added a commit to rust-lang-ci/rust that referenced this pull request Dec 11, 2022
…iaskrgr

Rollup of 7 pull requests

Successful merges:

 - rust-lang#103146 (Cleanup timeouts in pthread condvar)
 - rust-lang#105459 (Build rust-analyzer proc-macro server by default)
 - rust-lang#105460 (Bump compiler-builtins to 0.1.85)
 - rust-lang#105511 (Update rustix to 0.36.5)
 - rust-lang#105530 (Clean up lifetimes in rustdoc syntax highlighting)
 - rust-lang#105534 (Add Nilstrieb to compiler reviewers)
 - rust-lang#105542 (Some method confirmation code nits)

Failed merges:

r? `@ghost`
`@rustbot` modify labels: rollup
@bors bors merged commit 1a43beb into rust-lang:master Dec 11, 2022
@rustbot rustbot added this to the 1.68.0 milestone Dec 11, 2022
@Noratrieb Noratrieb deleted the rustdoc-highlight-less-lifetimes branch December 11, 2022 07:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-rustdoc Relevant to the rustdoc team, which will review and decide on the PR/issue.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants