Skip to content

Commit 90524da

Browse files
committed
Document why tidy checks if eslint is installed via npm
1 parent a30f178 commit 90524da

File tree

1 file changed

+3
-0
lines changed

1 file changed

+3
-0
lines changed

src/tools/tidy/src/rustdoc_js.rs

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -62,6 +62,9 @@ pub fn check(librustdoc_path: &Path, tools_path: &Path, src_path: &Path, bad: &m
6262
return;
6363
}
6464
};
65+
// Having the correct `eslint` version installed via `npm` isn't strictly necessary, since we're invoking it via `npx`,
66+
// but this check allows the vast majority that is not working on the rustdoc frontend to avoid the penalty of running
67+
// `eslint` in tidy. See also: https://github.com/rust-lang/rust/pull/142851
6568
match get_eslint_version() {
6669
Some(version) => {
6770
if version != eslint_version {

0 commit comments

Comments
 (0)