Fix error caused by recursion into Self.

Fixes #10041.

Prevent recusion into Self when it's a generic parameter.
Added regression test from example in #10041.

Author: Nashenas88

clippy_utils/src/ty.rs

@@ -90,6 +90,7 @@ pub fn contains_ty_adt_constructor_opaque<'tcx>(cx: &LateContext<'tcx>, ty: Ty<'
                                 .substs
                                 .types()
                                 .skip(1) // Skip the implicit `Self` generic parameter
+                                .filter(|inner_ty| *inner_ty != ty) // Skip any other `Self` generic parameters
                                 .any(|ty| contains_ty_adt_constructor_opaque(cx, ty, needle))
                             {
                                 return true;

tests/ui/new_ret_no_self.rs

@@ -400,3 +400,14 @@ mod issue7344 {
         }
     }
 }
+
+mod issue10041 {
+    struct Bomb;
+
+    impl Bomb {
+        // Hidden <Rhs = Self> default generic paramter.
+        pub fn explode(&self) -> impl PartialOrd {
+            0i32
+        }
+    }
+}