Handle rustc_on_unimplemented in duplicated_attributes

Author: Noratrieb

clippy_lints/src/attrs/duplicated_attributes.rs

@@ -37,9 +37,10 @@ fn check_duplicated_attr(
     }
     let Some(ident) = attr.ident() else { return };
     let name = ident.name;
-    if name == sym::doc || name == sym::cfg_attr {
+    if name == sym::doc || name == sym::cfg_attr || name == sym::rustc_on_unimplemented {
         // FIXME: Would be nice to handle `cfg_attr` as well. Only problem is to check that cfg
         // conditions are the same.
+        // `#[rustc_on_unimplemented]` contains duplicated subattributes, that's expected.
         return;
     }
     if let Some(direct_parent) = parent.last()

tests/ui/duplicated_attributes.rs

@@ -1,4 +1,5 @@
 #![warn(clippy::duplicated_attributes)]
+#![feature(rustc_attrs)]
 #![cfg(any(unix, windows))]
 #![allow(dead_code)]
 #![allow(dead_code)] //~ ERROR: duplicated attribute
@@ -15,4 +16,17 @@ fn foo() {}
 #[cfg(unix)] //~ ERROR: duplicated attribute
 fn bar() {}
 
+// No warning:
+#[rustc_on_unimplemented(
+    on(
+        _Self = "&str",
+        label = "`a"
+    ),
+    on(
+        _Self = "alloc::string::String",
+        label = "a"
+    ),
+)]
+trait Abc {}
+
 fn main() {}

tests/ui/duplicated_attributes.stderr

@@ -1,52 +1,52 @@
 error: duplicated attribute
-  --> tests/ui/duplicated_attributes.rs:4:10
+  --> tests/ui/duplicated_attributes.rs:5:10
    |
 LL | #![allow(dead_code)]
    |          ^^^^^^^^^
    |
 note: first defined here
-  --> tests/ui/duplicated_attributes.rs:3:10
+  --> tests/ui/duplicated_attributes.rs:4:10
    |
 LL | #![allow(dead_code)]
    |          ^^^^^^^^^
 help: remove this attribute
-  --> tests/ui/duplicated_attributes.rs:4:10
+  --> tests/ui/duplicated_attributes.rs:5:10
    |
 LL | #![allow(dead_code)]
    |          ^^^^^^^^^
    = note: `-D clippy::duplicated-attributes` implied by `-D warnings`
    = help: to override `-D warnings` add `#[allow(clippy::duplicated_attributes)]`
 
 error: duplicated attribute
-  --> tests/ui/duplicated_attributes.rs:9:9
+  --> tests/ui/duplicated_attributes.rs:10:9
    |
 LL | #[allow(dead_code)]
    |         ^^^^^^^^^
    |
 note: first defined here
-  --> tests/ui/duplicated_attributes.rs:8:9
+  --> tests/ui/duplicated_attributes.rs:9:9
    |
 LL | #[allow(dead_code)]
    |         ^^^^^^^^^
 help: remove this attribute
-  --> tests/ui/duplicated_attributes.rs:9:9
+  --> tests/ui/duplicated_attributes.rs:10:9
    |
 LL | #[allow(dead_code)]
    |         ^^^^^^^^^
 
 error: duplicated attribute
-  --> tests/ui/duplicated_attributes.rs:15:7
+  --> tests/ui/duplicated_attributes.rs:16:7
    |
 LL | #[cfg(unix)]
    |       ^^^^
    |
 note: first defined here
-  --> tests/ui/duplicated_attributes.rs:13:7
+  --> tests/ui/duplicated_attributes.rs:14:7
    |
 LL | #[cfg(unix)]
    |       ^^^^
 help: remove this attribute
-  --> tests/ui/duplicated_attributes.rs:15:7
+  --> tests/ui/duplicated_attributes.rs:16:7
    |
 LL | #[cfg(unix)]
    |       ^^^^