Use proper ids for server->client messages

Author: nrc

src/actions/mod.rs

@@ -471,7 +471,8 @@ impl ActionHandler {
         trace!("apply_suggestion {:?} {}", location, new_text);
         // FIXME should handle the response
         let output = serde_json::to_string(
-            &RequestMessage::new("workspace/applyEdit".to_owned(),
+            &RequestMessage::new(out.provide_id(),
+                                 "workspace/applyEdit".to_owned(),
                                  ApplyWorkspaceEditParams { edit: make_workspace_edit(location, new_text) })
         ).unwrap();
         out.response(output);
@@ -563,7 +564,8 @@ impl ActionHandler {
         // Send a workspace edit to make the actual change.
         // FIXME should handle the response
         let output = serde_json::to_string(
-            &RequestMessage::new("workspace/applyEdit".to_owned(),
+            &RequestMessage::new(out.provide_id(),
+                                 "workspace/applyEdit".to_owned(),
                                  ApplyWorkspaceEditParams { edit: make_workspace_edit(location, deglob_str) })
         ).unwrap();
         out.response(output);
@@ -658,14 +660,16 @@ impl ActionHandler {
                 // FIXME should handle the response
                 if unstable_features {
                     let output = serde_json::to_string(
-                        &RequestMessage::new(NOTIFICATION__RegisterCapability.to_owned(),
+                        &RequestMessage::new(out.provide_id(),
+                                             NOTIFICATION__RegisterCapability.to_owned(),
                                              RegistrationParams { registrations: vec![Registration { id: RANGE_FORMATTING_ID.to_owned(), method: REQUEST__RangeFormatting.to_owned(), register_options: serde_json::Value::Null },
                                                                                       Registration { id: RENAME_ID.to_owned(), method: REQUEST__Rename.to_owned(), register_options: serde_json::Value::Null }] })
                     ).unwrap();
                     out.response(output);
                 } else {
                     let output = serde_json::to_string(
-                        &RequestMessage::new(NOTIFICATION__UnregisterCapability.to_owned(),
+                        &RequestMessage::new(out.provide_id(),
+                                             NOTIFICATION__UnregisterCapability.to_owned(),
                                              UnregistrationParams { unregisterations: vec![Unregistration { id: RANGE_FORMATTING_ID.to_owned(), method: REQUEST__RangeFormatting.to_owned() },
                                                                                            Unregistration { id: RENAME_ID.to_owned(), method: REQUEST__Rename.to_owned() }] })
                     ).unwrap();

src/cmd.rs

@@ -193,6 +193,10 @@ impl server::Output for PrintlnOutput {
         println!("{}", output);
     }
 
+    fn provide_id(&self) -> u64 {
+        0
+    }
+
     fn success(&self, id: usize, data: ResponseData) {
         println!("{}: {:#?}", id, data);
     }

src/lsp_data.rs

@@ -200,16 +200,16 @@ pub struct RequestMessage<T>
     where T: Debug + Serialize
 {
     jsonrpc: &'static str,
-    pub id: String,
+    pub id: u64,
     pub method: String,
     pub params: T,
 }
 
 impl <T> RequestMessage<T> where T: Debug + Serialize {
-    pub fn new(method: String, params: T) -> Self {
+    pub fn new(id: u64, method: String, params: T) -> Self {
         RequestMessage {
             jsonrpc: "2.0",
-            id: "FIXME".to_owned(),
+            id,
             method: method,
             params: params
         }

src/main.rs

@@ -11,6 +11,7 @@
 #![feature(rustc_private)]
 #![feature(concat_idents)]
 #![feature(type_ascription)]
+#![feature(integer_atomics)]
 
 extern crate cargo;
 #[macro_use]

src/server.rs

@@ -18,7 +18,7 @@ use actions::ActionHandler;
 use std::fmt;
 use std::io::{self, Read, Write, ErrorKind};
 use std::sync::Arc;
-use std::sync::atomic::{AtomicBool, Ordering};
+use std::sync::atomic::{AtomicBool, Ordering, AtomicU64};
 use std::path::PathBuf;
 
 #[cfg(test)]
@@ -547,6 +547,7 @@ impl MessageReader for StdioMsgReader {
 
 pub trait Output: Sync + Send + Clone + 'static {
     fn response(&self, output: String);
+    fn provide_id(&self) -> u64;
 
     fn parse_error(&self) {
         self.response(r#"{"jsonrpc": "2.0", "error": {"code": -32700, "message": "Parse error"}, "id": null}"#.to_owned());
@@ -601,7 +602,17 @@ pub trait Output: Sync + Send + Clone + 'static {
 }
 
 #[derive(Clone)]
-struct StdioOutput;
+struct StdioOutput {
+    next_id: Arc<AtomicU64>,
+}
+
+impl StdioOutput {
+    pub fn new() -> StdioOutput {
+        StdioOutput {
+            next_id: Arc::new(AtomicU64::new(1)),
+        }
+    }
+}
 
 impl Output for StdioOutput {
     fn response(&self, output: String) {
@@ -612,14 +623,18 @@ impl Output for StdioOutput {
         print!("{}", o);
         io::stdout().flush().unwrap();
     }
+
+    fn provide_id(&self) -> u64 {
+        self.next_id.fetch_add(1, Ordering::SeqCst)
+    }
 }
 
 pub fn run_server(analysis: Arc<AnalysisHost>, vfs: Arc<Vfs>) {
     debug!("Language Server Starting up");
     let service = LsService::new(analysis,
                                  vfs,
                                  Box::new(StdioMsgReader),
-                                 StdioOutput);
+                                 StdioOutput::new());
     LsService::run(service);
     debug!("Server shutting down");
 }

src/test/harness.rs

@@ -89,6 +89,10 @@ impl ls_server::Output for RecordOutput {
         let mut records = self.output.lock().unwrap();
         records.push(output);
     }
+
+    fn provide_id(&self) -> u64 {
+        0
+    }
 }
 
 #[derive(Clone, Debug)]