Skip to content

Commit 66df3f5

Browse files
committed
Say why it occasionally makes sense to force RVV off
This is adapted from the comment on the feature that was added under the design that was previously explored. This way, the description will be present somewhere, even though it may be less discoverable here in `cmake.rs` than it would be in manifests.
1 parent dbbe477 commit 66df3f5

File tree

1 file changed

+3
-0
lines changed

1 file changed

+3
-0
lines changed

zng/cmake.rs

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -26,6 +26,9 @@ pub fn build_zlib_ng(target: &str, compat: bool) {
2626
{
2727
Some("OFF" | "NO" | "FALSE" | "0") => {
2828
// Force RVV off. This turns off RVV entirely, as well as the runtime check for it.
29+
// This is not usually necessary, but can be useful for building binaries portable
30+
// to systems that do not support RVV but where auto-detection fails to identify
31+
// this (as in https://github.com/zlib-ng/zlib-ng/issues/1705).
2932
cmake.define("WITH_RVV", "OFF");
3033
}
3134
Some("ON" | "YES" | "TRUE" | "1") => {

0 commit comments

Comments
 (0)