fix: add grace period to allow registry to start up (#282)

Added 10s grace period + timeout on registry container wait. This makes logging in to the custom registry more reliable.

Signed-off-by: ayush-panta <ayushkp@amazon.com>

Author: ayush-panta

tests/login.go

@@ -7,6 +7,7 @@ import (
 	"fmt"
 	"os"
 	"path/filepath"
+	"time"
 
 	"github.com/onsi/ginkgo/v2"
 	"github.com/onsi/gomega/gbytes"
@@ -42,14 +43,25 @@ func Login(o *option.Option) {
 				htpasswdDir := filepath.Dir(ffs.CreateTempFile(filename, htpasswd))
 				ginkgo.DeferCleanup(os.RemoveAll, htpasswdDir)
 				port := fnet.GetFreePort()
-				command.Run(o, "run",
+				containerID := command.StdoutStr(o, "run",
 					"-dp", fmt.Sprintf("%d:5000", port),
 					"--name", "registry",
 					"-v", fmt.Sprintf("%s:/auth", htpasswdDir),
 					"-e", "REGISTRY_AUTH=htpasswd",
 					"-e", "REGISTRY_AUTH_HTPASSWD_REALM=Registry Realm",
 					"-e", fmt.Sprintf("REGISTRY_AUTH_HTPASSWD_PATH=/auth/%s", filename),
 					registryImage)
+				// Wait for container to be running
+				tries := 0
+				for command.StdoutStr(o, "inspect", "-f", "{{.State.Running}}", containerID) != "true" {
+					if tries >= 5 {
+						ginkgo.Fail("Registry container failed to start after 5 seconds")
+					}
+					time.Sleep(1 * time.Second)
+					tries++
+				}
+				// Wait for registry service to be ready
+				time.Sleep(10 * time.Second)
 				registry = fmt.Sprintf(`localhost:%d`, port)
 				tag = fmt.Sprintf(`%s/test-login:tag`, registry)
 				buildContext := ffs.CreateBuildContext(fmt.Sprintf(`FROM %s

tests/logout.go

@@ -7,6 +7,7 @@ import (
 	"fmt"
 	"os"
 	"path/filepath"
+	"time"
 
 	"github.com/onsi/ginkgo/v2"
 
@@ -42,14 +43,25 @@ func Logout(o *option.Option) {
 				htpasswdDir := filepath.Dir(ffs.CreateTempFile(filename, htpasswd))
 				ginkgo.DeferCleanup(os.RemoveAll, htpasswdDir)
 				port := fnet.GetFreePort()
-				command.Run(o, "run",
+				containerID := command.StdoutStr(o, "run",
 					"-dp", fmt.Sprintf("%d:5000", port),
 					"--name", "registry",
 					"-v", fmt.Sprintf("%s:/auth", htpasswdDir),
 					"-e", "REGISTRY_AUTH=htpasswd",
 					"-e", "REGISTRY_AUTH_HTPASSWD_REALM=Registry Realm",
 					"-e", fmt.Sprintf("REGISTRY_AUTH_HTPASSWD_PATH=/auth/%s", filename),
 					registryImage)
+				// Wait for container to be running
+				tries := 0
+				for command.StdoutStr(o, "inspect", "-f", "{{.State.Running}}", containerID) != "true" {
+					if tries >= 5 {
+						ginkgo.Fail("Registry container failed to start after 5 seconds")
+					}
+					time.Sleep(1 * time.Second)
+					tries++
+				}
+				// Wait for registry service to be ready
+				time.Sleep(10 * time.Second)
 				registry = fmt.Sprintf(`localhost:%d`, port)
 				tag = fmt.Sprintf(`%s/test-login:tag`, registry)
 				buildContext := ffs.CreateBuildContext(fmt.Sprintf(`FROM %s