Merge pull request #48 from gordonbondon/httponly

Setting samesite and httponly

Author: route

README.md

@@ -572,6 +572,8 @@ Sets given values as cookie
   * :value `String`
   * :domain `String`
   * :expires `Integer`
+  * :samesite `String`
+  * :httponly `Boolean`
 
 ```ruby
 browser.cookies.set(name: "stealth", value: "omg", domain: "google.com") # => true

lib/ferrum/cookies.rb

@@ -23,6 +23,10 @@ def path
         @attributes["path"]
       end
 
+      def samesite
+        @attributes["sameSite"]
+      end
+
       def size
         @attributes["size"]
       end
@@ -65,6 +69,9 @@ def set(name: nil, value: nil, **options)
       cookie[:value]  ||= value
       cookie[:domain] ||= default_domain
 
+      cookie[:httpOnly] = cookie.delete(:httponly) if cookie.key?(:httponly)
+      cookie[:sameSite] = cookie.delete(:samesite) if cookie.key?(:samesite)
+
       expires = cookie.delete(:expires).to_i
       cookie[:expires] = expires if expires > 0
 

spec/cookies_spec.rb

@@ -27,7 +27,13 @@ module Ferrum
       end
 
       it "can set cookies with custom settings" do
-        browser.cookies.set(name: "stealth", value: "omg", path: "/ferrum")
+        browser.cookies.set(
+          name: "stealth",
+          value: "omg",
+          path: "/ferrum",
+          httponly: true,
+          samesite: "None"
+        )
 
         browser.goto("/get_cookie")
         expect(browser.body).to_not include("omg")
@@ -36,6 +42,8 @@ module Ferrum
         expect(browser.body).to include("omg")
 
         expect(browser.cookies["stealth"].path).to eq("/ferrum")
+        expect(browser.cookies["stealth"].httponly?).to be_truthy
+        expect(browser.cookies["stealth"].samesite).to eq("None")
       end
 
       it "can remove a cookie" do