Skip to content

Commit 1156824

Browse files
committed
v2.6.0 - Minor fixes release, closed issues #77 and #80
1 parent f48a46d commit 1156824

File tree

5 files changed

+32
-55
lines changed

5 files changed

+32
-55
lines changed

app/build.gradle

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -14,8 +14,8 @@ android {
1414
minSdkVersion 21
1515
resConfigs "en,ru"
1616
targetSdkVersion 31
17-
versionCode 259
18-
versionName "2.5.9"
17+
versionCode 260
18+
versionName "2.6.0"
1919

2020
kapt {
2121
arguments {

app/src/main/java/com/rtbishop/look4sat/presentation/mapScreen/MapFragment.kt

Lines changed: 24 additions & 38 deletions
Original file line numberDiff line numberDiff line change
@@ -70,7 +70,7 @@ class MapFragment : Fragment(R.layout.fragment_map) {
7070
mapView.apply {
7171
setMultiTouchControls(true)
7272
setTileSource(TileSourceFactory.WIKIMEDIA)
73-
minZoomLevel = getMinZoom(resources.displayMetrics.heightPixels)
73+
minZoomLevel = getMinZoom(resources.displayMetrics.heightPixels) + 0.25
7474
maxZoomLevel = 5.75
7575
controller.setZoom(minZoomLevel + 0.25)
7676
zoomController.setVisibility(CustomZoomButtonsController.Visibility.NEVER)
@@ -113,42 +113,24 @@ class MapFragment : Fragment(R.layout.fragment_map) {
113113
binding.apply {
114114
val markers = FolderOverlay()
115115
posMap.entries.forEach {
116-
if (viewModel.shouldUseTextLabels()) {
117-
Marker(mapView).apply {
118-
setInfoWindow(null)
119-
textLabelFontSize = 24
120-
textLabelBackgroundColor = Color.TRANSPARENT
121-
textLabelForegroundColor =
122-
ContextCompat.getColor(requireContext(), R.color.themeLight)
123-
setTextIcon(it.key.params.name)
124-
setAnchor(Marker.ANCHOR_CENTER, Marker.ANCHOR_CENTER)
125-
try {
126-
position = GeoPoint(it.value.latitude, it.value.longitude)
127-
} catch (exception: IllegalArgumentException) {
128-
Timber.d(exception)
129-
}
130-
setOnMarkerClickListener { _, _ ->
131-
viewModel.selectSatellite(it.key)
132-
return@setOnMarkerClickListener true
133-
}
134-
markers.add(this)
116+
Marker(mapView).apply {
117+
setInfoWindow(null)
118+
textLabelFontSize = 24
119+
textLabelBackgroundColor = Color.TRANSPARENT
120+
textLabelForegroundColor =
121+
ContextCompat.getColor(requireContext(), R.color.themeLight)
122+
setTextIcon(it.key.params.name)
123+
setAnchor(Marker.ANCHOR_CENTER, Marker.ANCHOR_CENTER)
124+
try {
125+
position = GeoPoint(it.value.latitude, it.value.longitude)
126+
} catch (exception: IllegalArgumentException) {
127+
Timber.d(exception)
135128
}
136-
} else {
137-
Marker(mapView).apply {
138-
setInfoWindow(null)
139-
setAnchor(Marker.ANCHOR_CENTER, Marker.ANCHOR_CENTER)
140-
icon = ContextCompat.getDrawable(requireContext(), R.drawable.ic_map_sat)
141-
try {
142-
position = GeoPoint(it.value.latitude, it.value.longitude)
143-
} catch (exception: IllegalArgumentException) {
144-
Timber.d(exception)
145-
}
146-
setOnMarkerClickListener { _, _ ->
147-
viewModel.selectSatellite(it.key)
148-
return@setOnMarkerClickListener true
149-
}
150-
markers.add(this)
129+
setOnMarkerClickListener { _, _ ->
130+
viewModel.selectSatellite(it.key)
131+
return@setOnMarkerClickListener true
151132
}
133+
markers.add(this)
152134
}
153135
}
154136
mapView.overlays[3] = markers
@@ -161,9 +143,13 @@ class MapFragment : Fragment(R.layout.fragment_map) {
161143
satTrack.forEach { track ->
162144
val trackPoints = track.map { GeoPoint(it.latitude, it.longitude) }
163145
Polyline().apply {
164-
outlinePaint.set(trackPaint)
165-
setPoints(trackPoints)
166-
trackOverlay.add(this)
146+
try {
147+
setPoints(trackPoints)
148+
outlinePaint.set(trackPaint)
149+
trackOverlay.add(this)
150+
} catch (exception: IllegalArgumentException) {
151+
Timber.d(exception)
152+
}
167153
}
168154
}
169155
binding.mapView.overlays[1] = trackOverlay

app/src/main/res/xml/preference.xml

Lines changed: 0 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -57,15 +57,6 @@
5757
app:iconSpaceReserved="false"
5858
app:useSimpleSummaryProvider="true" />
5959
</PreferenceCategory>
60-
<PreferenceCategory
61-
android:title="@string/pref_map_labels_title"
62-
app:iconSpaceReserved="false">
63-
<SwitchPreferenceCompat
64-
android:defaultValue="true"
65-
android:key="shouldUseTextLabels"
66-
android:title="@string/pref_map_labels"
67-
app:iconSpaceReserved="false" />
68-
</PreferenceCategory>
6960
<PreferenceCategory
7061
android:title="@string/pref_other_title"
7162
app:iconSpaceReserved="false">
Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,3 @@
1+
Fixed James Webb Space Telescope crash
2+
However still reporting erroneous data
3+
Fixed DataParser bug, issues #77 & #80
Lines changed: 3 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,3 @@
1-
Restored missing app icons for low-res/api screens
2-
Removed redundant material components
3-
Fixed Redmi dark theme colors bug
4-
Fixed RemoteSource update crash
5-
Matched CSV and TLE parsers output
6-
Further code refactoring and cleanup
1+
Fixed James Webb Space Telescope crash
2+
However still reporting erroneous data
3+
Fixed DataParser bug, issues #77 & #80

0 commit comments

Comments
 (0)