Easy ones

Author: gftabor

nav2_behavior_tree/test/plugins/condition/test_initial_pose_received.cpp

@@ -26,7 +26,7 @@ class InitialPoseReceivedConditionTestFixture : public nav2_behavior_tree::Behav
 public:
   void SetUp()
   {
-    config_->input_ports["initial_pose_received"] = 0;
+    config_->input_ports["initial_pose_received"] = false;
     bt_node_ = std::make_shared<nav2_behavior_tree::InitialPoseReceived>("TestNode", *config_);
   }
 

nav2_common/cmake/nav2_package.cmake

@@ -37,7 +37,7 @@ macro(nav2_package)
   endif()
 
   if(CMAKE_CXX_COMPILER_ID MATCHES "GNU" OR CMAKE_CXX_COMPILER_ID MATCHES "Clang")
-    add_compile_options(-Wall -Wextra -Wpedantic -Wdeprecated -fPIC -Wshadow -Wnull-dereference)
+    add_compile_options(-Wall -Wextra -Wpedantic -Werror -Wdeprecated -fPIC -Wshadow -Wnull-dereference)
     add_compile_options("$<$<COMPILE_LANGUAGE:CXX>:-Wnon-virtual-dtor>")
   endif()
 

nav2_map_server/CMakeLists.txt

@@ -147,15 +147,6 @@ install(DIRECTORY include/
 
 install(DIRECTORY launch DESTINATION share/${PROJECT_NAME})
 
-if(BUILD_TESTING)
-  find_package(ament_lint_auto REQUIRED)
-  # the following line skips the linter which checks for copyrights
-  set(ament_cmake_copyright_FOUND TRUE)
-  ament_lint_auto_find_test_dependencies()
-
-  find_package(ament_cmake_gtest REQUIRED)
-  add_subdirectory(test)
-endif()
 
 ament_export_include_directories(include)
 ament_export_libraries(

nav2_rviz_plugins/CMakeLists.txt

@@ -7,7 +7,7 @@ if(NOT CMAKE_CXX_STANDARD)
 endif()
 
 if(CMAKE_CXX_COMPILER_ID MATCHES "GNU" OR CMAKE_CXX_COMPILER_ID MATCHES "Clang")
-  add_compile_options(-Wall -Wextra -Wpedantic)
+  add_compile_options(-Wall -Wextra -Wpedantic -Werror)
 endif()
 
 # Qt5 boilerplate options from http://doc.qt.io/qt-5/cmake-manual.html