Skip to content

Commit ae34792

Browse files
author
orebai
committed
fix: Rename PushRosNamespace to PushROSNamespace for consistency across launch files
1 parent a1d4671 commit ae34792

File tree

5 files changed

+15
-15
lines changed

5 files changed

+15
-15
lines changed

nav2_bringup/launch/keepout_zone_launch.py

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -19,7 +19,7 @@
1919
from launch.actions import DeclareLaunchArgument, GroupAction, SetEnvironmentVariable
2020
from launch.conditions import IfCondition
2121
from launch.substitutions import LaunchConfiguration, PythonExpression
22-
from launch_ros.actions import LoadComposableNodes, Node, PushRosNamespace, SetParameter
22+
from launch_ros.actions import LoadComposableNodes, Node, PushROSNamespace, SetParameter
2323
from launch_ros.descriptions import ComposableNode, ParameterFile
2424
from nav2_common.launch import LaunchConfigAsBool, RewrittenYaml
2525

@@ -116,7 +116,7 @@ def generate_launch_description() -> LaunchDescription:
116116
load_nodes = GroupAction(
117117
condition=IfCondition(PythonExpression(['not ', use_composition])),
118118
actions=[
119-
PushRosNamespace(namespace),
119+
PushROSNamespace(namespace),
120120
SetParameter('use_sim_time', use_sim_time),
121121
Node(
122122
condition=IfCondition(use_keepout_zones),
@@ -160,7 +160,7 @@ def generate_launch_description() -> LaunchDescription:
160160
load_composable_nodes = GroupAction(
161161
condition=IfCondition(use_composition),
162162
actions=[
163-
PushRosNamespace(namespace),
163+
PushROSNamespace(namespace),
164164
SetParameter('use_sim_time', use_sim_time),
165165
LoadComposableNodes(
166166
target_container=container_name_full,

nav2_bringup/launch/localization_launch.py

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -20,7 +20,7 @@
2020
from launch.conditions import IfCondition
2121
from launch.substitutions import (EqualsSubstitution, LaunchConfiguration, NotEqualsSubstitution,
2222
PythonExpression)
23-
from launch_ros.actions import LoadComposableNodes, Node, PushRosNamespace, SetParameter
23+
from launch_ros.actions import LoadComposableNodes, Node, PushROSNamespace, SetParameter
2424
from launch_ros.descriptions import ComposableNode, ParameterFile
2525
from nav2_common.launch import LaunchConfigAsBool, RewrittenYaml
2626

@@ -110,7 +110,7 @@ def generate_launch_description() -> LaunchDescription:
110110
load_nodes = GroupAction(
111111
condition=IfCondition(PythonExpression(['not ', use_composition])),
112112
actions=[
113-
PushRosNamespace(namespace),
113+
PushROSNamespace(namespace),
114114
SetParameter('use_sim_time', use_sim_time),
115115
Node(
116116
condition=IfCondition(
@@ -169,7 +169,7 @@ def generate_launch_description() -> LaunchDescription:
169169
load_composable_nodes = GroupAction(
170170
condition=IfCondition(use_composition),
171171
actions=[
172-
PushRosNamespace(namespace),
172+
PushROSNamespace(namespace),
173173
SetParameter('use_sim_time', use_sim_time),
174174
LoadComposableNodes(
175175
target_container=container_name_full,

nav2_bringup/launch/navigation_launch.py

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -19,7 +19,7 @@
1919
from launch.actions import DeclareLaunchArgument, GroupAction, SetEnvironmentVariable
2020
from launch.conditions import IfCondition
2121
from launch.substitutions import LaunchConfiguration, PythonExpression
22-
from launch_ros.actions import LoadComposableNodes, Node, PushRosNamespace, SetParameter
22+
from launch_ros.actions import LoadComposableNodes, Node, PushROSNamespace, SetParameter
2323
from launch_ros.descriptions import ComposableNode, ParameterFile
2424
from nav2_common.launch import LaunchConfigAsBool, RewrittenYaml
2525

@@ -133,7 +133,7 @@ def generate_launch_description() -> LaunchDescription:
133133
condition=IfCondition(PythonExpression(['not ', use_composition])),
134134
actions=[
135135
SetParameter('use_sim_time', use_sim_time),
136-
PushRosNamespace(namespace=namespace),
136+
PushROSNamespace(namespace=namespace),
137137
Node(
138138
package='nav2_controller',
139139
executable='controller_server',
@@ -258,7 +258,7 @@ def generate_launch_description() -> LaunchDescription:
258258
condition=IfCondition(use_composition),
259259
actions=[
260260
SetParameter('use_sim_time', use_sim_time),
261-
PushRosNamespace(namespace=namespace),
261+
PushROSNamespace(namespace=namespace),
262262
LoadComposableNodes(
263263
target_container=container_name_full,
264264
composable_node_descriptions=[

nav2_bringup/launch/slam_launch.py

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -20,7 +20,7 @@
2020
from launch.conditions import IfCondition, UnlessCondition
2121
from launch.launch_description_sources import PythonLaunchDescriptionSource
2222
from launch.substitutions import LaunchConfiguration
23-
from launch_ros.actions import Node, PushRosNamespace, SetParameter, SetRemap
23+
from launch_ros.actions import Node, PushROSNamespace, SetParameter, SetRemap
2424
from launch_ros.descriptions import ParameterFile
2525
from nav2_common.launch import HasNodeParams, LaunchConfigAsBool, RewrittenYaml
2626

@@ -89,7 +89,7 @@ def generate_launch_description() -> LaunchDescription:
8989
# Nodes launching commands
9090
start_map_server = GroupAction(
9191
actions=[
92-
PushRosNamespace(namespace),
92+
PushROSNamespace(namespace),
9393
SetParameter('use_sim_time', use_sim_time),
9494
Node(
9595
package='nav2_map_server',
@@ -121,7 +121,7 @@ def generate_launch_description() -> LaunchDescription:
121121
start_slam_toolbox_cmd = GroupAction(
122122

123123
actions=[
124-
PushRosNamespace(namespace),
124+
PushROSNamespace(namespace),
125125

126126
# Remapping required to have a slam session subscribe & publish in optional namespaces
127127
SetRemap(src='/scan', dst='scan'),

nav2_bringup/launch/speed_zone_launch.py

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -19,7 +19,7 @@
1919
from launch.actions import DeclareLaunchArgument, GroupAction, SetEnvironmentVariable
2020
from launch.conditions import IfCondition
2121
from launch.substitutions import LaunchConfiguration, PythonExpression
22-
from launch_ros.actions import LoadComposableNodes, Node, PushRosNamespace, SetParameter
22+
from launch_ros.actions import LoadComposableNodes, Node, PushROSNamespace, SetParameter
2323
from launch_ros.descriptions import ComposableNode, ParameterFile
2424
from nav2_common.launch import LaunchConfigAsBool, RewrittenYaml
2525

@@ -116,7 +116,7 @@ def generate_launch_description() -> LaunchDescription:
116116
load_nodes = GroupAction(
117117
condition=IfCondition(PythonExpression(['not ', use_composition])),
118118
actions=[
119-
PushRosNamespace(namespace),
119+
PushROSNamespace(namespace),
120120
SetParameter('use_sim_time', use_sim_time),
121121
Node(
122122
condition=IfCondition(use_speed_zones),
@@ -160,7 +160,7 @@ def generate_launch_description() -> LaunchDescription:
160160
load_composable_nodes = GroupAction(
161161
condition=IfCondition(use_composition),
162162
actions=[
163-
PushRosNamespace(namespace),
163+
PushROSNamespace(namespace),
164164
SetParameter('use_sim_time', use_sim_time),
165165
LoadComposableNodes(
166166
target_container=container_name_full,

0 commit comments

Comments
 (0)