Merge pull request flutter#10 from dart-lang/failingTest-fail-when-pass

Fail @failingTest when the test passes.

Author: scheglov

CHANGELOG.md

@@ -1,5 +1,9 @@
 # Changelog
 
+## 0.1.3
+
+- Fix `@failingTest` to fail when the test passes.
+
 ## 0.1.2
 
 - Update the pubspec `dependencies` section to include `package:test`

lib/test_reflective_loader.dart

@@ -226,14 +226,24 @@ Future _invokeSymbolIfExists(InstanceMirror instanceMirror, Symbol symbol) {
  * - An exception is thrown to the zone handler from a timer task.
  */
 Future _runFailingTest(ClassMirror classMirror, Symbol symbol) {
+  bool passed = false;
   return runZoned(() {
     return new Future.sync(() => _runTest(classMirror, symbol)).then((_) {
+      passed = true;
       test_package.fail('Test passed - expected to fail.');
     }).catchError((e) {
-      // an exception is not a failure for _runFailingTest
+      // if passed, and we call fail(), rethrow this exception
+      if (passed) {
+        throw e;
+      }
+      // otherwise, an exception is not a failure for _runFailingTest
     });
   }, onError: (e) {
-    // an exception is not a failure for _runFailingTest
+    // if passed, and we call fail(), rethrow this exception
+    if (passed) {
+      throw e;
+    }
+    // otherwise, an exception is not a failure for _runFailingTest
   });
 }
 

pubspec.yaml

@@ -1,5 +1,5 @@
 name: test_reflective_loader
-version: 0.1.2
+version: 0.1.3
 description: Support for discovering tests and test suites using reflection.
 author: Dart Team <[email protected]>
 homepage: https://github.com/dart-lang/test_reflective_loader